Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages
Date: Wed, 13 Jan 2021 14:50:11
Message-Id: uv9c0riwd@gentoo.org
In Reply to: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages by "Michał Górny"
1 >>>>> On Wed, 13 Jan 2021, Michał Górny wrote:
2 > + local success=
3 > + while :; do
4 > + mount-boot_pkg_preinst
5 > +
6 > + local image_path=$(dist-kernel_get_image_path)
7 > + if use initramfs; then
8 > + # putting it alongside kernel image as 'initrd' makes
9 > + # kernel-install happier
10 > + nonfatal dist-kernel_build_initramfs \
11 > + "${EROOT}/usr/src/linux-${ver}/${image_path%/*}/initrd" \
12 > + "${ver}" || break
13 > + fi
14 >
15 > - dist-kernel_install_kernel "${ver}" \
16 > - "${EROOT}/usr/src/linux-${ver}/${image_path}" \
17 > - "${EROOT}/usr/src/linux-${ver}/System.map"
18 > + nonfatal dist-kernel_install_kernel "${ver}" \
19 > + "${EROOT}/usr/src/linux-${ver}/${image_path}" \
20 > + "${EROOT}/usr/src/linux-${ver}/System.map" || break
21 > +
22 > + success=1
23 > + break
24 > + done
25
26 Looks like this loop can run only once, so it is redundant?
27
28 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies