Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH autotools-utils 1/4] Support installing default docs, similarly to EAPI4.
Date: Sat, 07 Jan 2012 10:47:13
Message-Id: 20232.8836.740058.282212@a1i15.kph.uni-mainz.de
In Reply to: Re: [gentoo-dev] [PATCH autotools-utils 1/4] Support installing default docs, similarly to EAPI4. by "Michał Górny"
1 >>>>> On Sat, 7 Jan 2012, Micha³ Górny wrote:
2
3 > On Sat, 7 Jan 2012 11:05:09 +0100
4 > Ulrich Mueller <ulm@g.o> wrote:
5
6 >> Yes, unfortunately some eclasses support DOCS only as an array,
7 >> others only as a space-separated list.
8 >>
9 >> IMHO, when such code is touched, it should be changed in a way that
10 >> both forms are supported, i.e. to behave like the EAPI 4 default.
11
12 > And IMHO all that 'others' should be modified to support bash
13 > arrays.
14
15 I guess a better solution would be to have an install_docs (or
16 whatever it'd be named) function in eutils.eclass so that other
17 eclasses could just call it. This should be identical with the EAPI 4
18 default, i.e. the second half of _eapi4_src_install() in Portage.
19
20 It doesn't make sense to have duplicate code in many eclasses.
21
22 > Or bash should be modified to support using space-separated lists as
23 > arrays because the current behavior is ridiculous.
24
25 I would already be happy if there was an easier way to check the type
26 of a variable than to parse the output of "declare -p". ;-)
27
28 Ulrich