Gentoo Archives: gentoo-dev

From: Kent Fredric <kentnl@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] bash-4.4 - call for testers
Date: Sun, 02 Oct 2016 07:37:15
Message-Id: 20161002184044.54e5f1e6@katipo2.lan
In Reply to: Re: [gentoo-dev] bash-4.4 - call for testers by konsolebox
1 On Sun, 2 Oct 2016 13:28:04 +0800
2 konsolebox <konsolebox@×××××.com> wrote:
3
4 > I guess that's another good way to solve the readline issue (when it
5 > comes to bash). But I'd prefer that it's not done automatically.
6 > Instead we should add a formal use flag like 'installed-readline'. We
7 > can add it to release versions of bash ([[ ${PV} != *_rc* ]] &&
8 > IUSE+=' +installed-readline'), and enable it by default. Then we
9 > change all `[[ ${PV} != *_rc* ]]` condition checks to `[[ ${PV} !=
10 > *_rc* ]] && use installed-readline`. `${PV} != *_rc*` probably should
11 > also be `${PV} != *_alpha* && ${PV} != *_beta* && ${PV} != *_rc*`.
12 > (See attached file for POC.)
13
14 Conventionally, it would be better to have IUSE=" +system-readline"
15
16 Though I'd probably opt for
17
18 IUSE=" system-readline"
19
20 As the default for development versions.
21
22
23 if [[ ${PV} != *_rc* ]]; then
24 IUSE+=" system-readline"
25 else;
26 IUSE+=" +system-readline"
27 fi

Replies

Subject Author
Re: [gentoo-dev] bash-4.4 - call for testers konsolebox <konsolebox@×××××.com>