| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
Several reasons for discouraging -m. Here are two (there may be others) |
| 5 |
: |
| 6 |
Firstly, with repoman commit, -m prepends "category/pkgname:" which is |
| 7 |
the style required as per the git workflow wiki. |
| 8 |
Additionally, for both repoman commit and git commit opening in an |
| 9 |
editor allows the user to make sure the first line is under 80 chars |
| 10 |
and enables the user to more easily conform to the desired format by |
| 11 |
having additional information on lines >=3 |
| 12 |
|
| 13 |
On 01/17/2016 05:22 PM, Göktürk Yüksek wrote: |
| 14 |
> Manuel Rüger: |
| 15 |
>> On 17.01.2016 08:55, Gokturk Yuksek wrote: |
| 16 |
>>> Replace "cvs commit" with the equivalent "git add && git |
| 17 |
>>> commit" version. |
| 18 |
>>> |
| 19 |
>>> X-Gentoo-Bug-URL: |
| 20 |
>>> https://bugs.gentoo.org/show_bug.cgi?id=558642 Signed-off-by: |
| 21 |
>>> Gokturk Yuksek <gokturk@××××××××××.edu> |
| 22 |
>>> |
| 23 |
>>> diff --git a/ebuild-writing/misc-files/metadata/text.xml |
| 24 |
>>> b/ebuild-writing/misc-files/metadata/text.xml index |
| 25 |
>>> e506b1c..a8beacc 100644 --- |
| 26 |
>>> a/ebuild-writing/misc-files/metadata/text.xml +++ |
| 27 |
>>> b/ebuild-writing/misc-files/metadata/text.xml @@ -532,7 +532,8 |
| 28 |
>>> @@ is currently: <pre> xmllint --noout --valid metadata.xml |
| 29 |
>>> glep31check metadata.xml -cvs commit -m "Adding category |
| 30 |
>>> metadata.xml for my-category" metadata.xml +git add |
| 31 |
>>> metadata.xml +git commit --gpg-sign -m "Adding category |
| 32 |
>>> metadata.xml for my-category" </pre> |
| 33 |
>>> |
| 34 |
>>> </body> |
| 35 |
>>> |
| 36 |
> |
| 37 |
>> Can we discourage to use "-m" and prefer to open up an editor |
| 38 |
>> instead? |
| 39 |
> |
| 40 |
> I think the purpose of "-m" is only to illustrate the example of |
| 41 |
> adding a category with a proper message rather than suggesting a |
| 42 |
> workflow. Note that the section for committing packages suggests |
| 43 |
> "repoman commit" which opens up an editor by default. |
| 44 |
> |
| 45 |
> Is there a particular reason why we should discourage the use of |
| 46 |
> "-m"? |
| 47 |
> |
| 48 |
>> Cheers, |
| 49 |
> |
| 50 |
>> Manuel |
| 51 |
> |
| 52 |
> |
| 53 |
> |
| 54 |
|
| 55 |
- -- |
| 56 |
NP-Hardass |
| 57 |
-----BEGIN PGP SIGNATURE----- |
| 58 |
Version: GnuPG v2 |
| 59 |
|
| 60 |
iQIcBAEBCAAGBQJWnCFkAAoJEBzZQR2yrxj7p54P/2gBHfvyEJx59VrMSUZm/ZZi |
| 61 |
fzQcOeOjRHWtI1Uz1f15J2eVjq0qQ+B8Wddczsq9Xj70sb8Bgd42B87Im+qo8AmD |
| 62 |
2DJVkAveOEOd8UTz6BOkRqksYc2EDHLMv9Nu4ZukAdM56NwNQEfE2du9N/sOVr1D |
| 63 |
LAuni26JD2nhIGc749qwUX46gijGEww5gOwNEtMlSS59XeLuYnWSDacxKj19zApM |
| 64 |
Zx8HfHlysILT8EkM0HZ73fKEcAfT7ZKbgq2rKlPv4FwogprNcj/IWasD5o9d2d7b |
| 65 |
0zFLExdBMGVHGHDc1hu8M8ofFB0B0cRa+3QEJX3hvSxPOqmRtb8E3GAu20JtPJ69 |
| 66 |
UVivK7CT1qQIaLuIlGC95Ny06ZRLKp5mNQ1Del6pDDJHjs3b2O3P1wTTNH/RuE5V |
| 67 |
MZGKQpLojpmNTepOiBbOxfKJjvDhoQ5yzJ7qw0q4K23awRPj5j/5plKt8kwznySH |
| 68 |
EBNLqRl8E+Q1BJ91wNJZVtXtOhc0Lu+03cEJ95D1f55sOUdStnjBaMiZAKP3gswa |
| 69 |
YWdaRsONtuCx6BEhILdd0lVOnCIz75YwW8Le3DyitLO3Klf9WA2EeYAYmWmiLpas |
| 70 |
L6Z7SU1I0M//gJFq1JdeEAZGNoVoVQJBVQ04tM+9VMxijmGdArzdRmye41J+60ZR |
| 71 |
ctBkIkyPn5mlmrOp/Qxo |
| 72 |
=pg/V |
| 73 |
-----END PGP SIGNATURE----- |
Archives