Gentoo Archives: gentoo-dev

From: "Daniel Campbell (zlg)" <zlg@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/)
Date: Sun, 09 Aug 2015 23:59:03
Message-Id: 55C7E93E.70506@gentoo.org
In Reply to: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/) by Davide Pesavento
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 08/09/2015 11:49 AM, Davide Pesavento wrote:
5 > On Sun, Aug 9, 2015 at 8:43 AM, Mike Gilbert <floppym@g.o>
6 > wrote:
7 >> On Sun, Aug 9, 2015 at 11:30 AM, hasufell <hasufell@g.o>
8 >> wrote:
9 >>> On 08/09/2015 05:19 PM, Tobias Klausmann wrote:
10 >>>> Hi!
11 >>>>
12 >>>> On Sun, 09 Aug 2015, Sven Vermeulen wrote:
13 >>>>
14 >>>>> On Sun, Aug 09, 2015 at 04:43:36PM +0200, Dirkjan Ochtman
15 >>>>> wrote:
16 >>>>>>> I think "X-Gentoo-Bug: 557022" also makes the job
17 >>>>>>> easier for tools that parse commit messages.
18 >>>>>>
19 >>>>>> I don't. Just the "bug " prefix should be fine for almost
20 >>>>>> all purposes, even for tools.
21 >>>>>
22 >>>>> I'm pretty sure the majority of developers don't care that
23 >>>>> one developer uses "X-Gentoo-Bug" and another just adds it
24 >>>>> to the commit title.
25 >>>>>
26 >>>>> I like /guidelines/ in the sense that, if I don't know
27 >>>>> something, I can look it up. But don't make it mandatory
28 >>>>> until we start depending on it (for instance, when we would
29 >>>>> automate stuff based on the content of the commit
30 >>>>> message).
31 >>>>
32 >>>> I'd just go with "Gentoo-Bug". The X- is pointless since it
33 >>>> was for eXtending Email-Headers. And what we do is only
34 >>>> linked in style.
35 >>>>
36 >>>
37 >>> I'd be fine with that and add a reference to the kernel
38 >>> guideline [0] to the wiki as well, so that it is clear that we
39 >>> also allow/use Acked-by, Reviewed-by, Suggested-by and
40 >>> whatnot.
41 >>>
42 >>> I'll wait for more ++ though.
43 >>
44 >> I like Gentoo-Bug. Much nicer without the X-.
45 >>
46 >
47 > +1 for Gentoo-Bug (or Gentoo-bug? not sure about the
48 > capitalization)
49 >
50 I guess I'm the third +1 here. Gentoo-Bug: xxxxxx is far better than
51 linking to it, since the URL scheme may change in the future. Bug
52 number is not likely to and it's clear what the number is referring to.
53
54 - --
55 Daniel Campbell - Gentoo Developer
56 OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net
57 fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6
58 -----BEGIN PGP SIGNATURE-----
59 Version: GnuPG v2
60
61 iQIcBAEBCAAGBQJVx+k8AAoJEAEkDpRQOeFwff8P/ROogCO8pBB7GH7epA3E/ObZ
62 udQIG8qupPiXfY9JUSR64ST4qNeeRL9Exu0RqeicgbLWdm0fXfmVkxzFmtGjahlp
63 nkNIGQOZX4f8Y27+2Ly9HO3oJqTNVq6sKgJBNkRnybOhqOFgaqEYWiJUZVdcNfUZ
64 7G1aS3MXTxysG2CzQwt3sEQSoMFKwp1PetXgF2f4ZsQlr/wHkyyd3yllQyKS9iqK
65 VG+IawTTYylQa04MTn8V9oW0jdoU8uL0HEH+3FKFZJq7t2bGT/GsW6iIxW78kaVt
66 iBQCkW6CK24IFRnP31oz8zuwbtK6OFg1Cx5fIRYYfsvaqCDzg5HqV81I5iZ61ZEr
67 GWUwoHYRXrw2RG6kC0V6TyvOVUDGTAGA+9jYIRNkMJtNhTlDosztyhCmkXLvajZE
68 QWXQ4FYXJy0OXytk1kK2+6cRNUJLhz/QfwXOlsSQNHfcCJuZQJ2xN73twzOpSPo+
69 ZCDclX84MV+cLJslZZVLNcjWToE/LZLw4a1VKvt3MDOAlhpMiPfcABWB65RcR7N4
70 7LcOM6APIsaYsJsgsZDSNlq5ckIkqZk55d6S7LADHwbyQac/o7kP05atGOuiaw9/
71 EbmTcXoM73+oemhce/dGc5/iPH+JYkoAkN94pbqWhj4wWykatcmE2TW1FLNPZdmi
72 /a0RFqIXsv8k9y0MZvEs
73 =ydn7
74 -----END PGP SIGNATURE-----