Re: [gentoo-dev] [PATCH 2/9] ruby-ng-gnome2.eclass: drop support for <EAPI=4

[Naohiro Aota]

On Sun, Feb 16, 2020 at 06:40:08AM +0100, Michał Górny wrote:
> On Sat, 2020-02-15 at 21:18 +0900, Naohiro Aota wrote:
> > Signed-off-by: Naohiro Aota <naota@g.o>
> > ---
> >  eclass/ruby-ng-gnome2.eclass | 13 +++----------
> >  1 file changed, 3 insertions(+), 10 deletions(-)
> >
> > diff --git a/eclass/ruby-ng-gnome2.eclass b/eclass/ruby-ng-gnome2.eclass
> > index 4e3c30017e9b..8c8e0c8c0a50 100644
> > --- a/eclass/ruby-ng-gnome2.eclass
> > +++ b/eclass/ruby-ng-gnome2.eclass
> > @@ -6,14 +6,14 @@
> >  # Ruby herd <ruby@g.o>
> >  # @AUTHOR:
> >  # Author: Hans de Graaff <graaff@g.o>
> > -# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6
> > +# @SUPPORTED_EAPIS: 4 5 6
> >  # @BLURB: An eclass to simplify handling of various ruby-gnome2 parts.
> >  # @DESCRIPTION:
> >  # This eclass simplifies installation of the various pieces of
> >  # ruby-gnome2 since they share a very common installation procedure.
> >
> >  case "${EAPI:-0}" in
> > -	0|1|2|3|4|5|6)
> > +	4|5|6)
> >  		;;
> >  	*)
> >  		die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
> >
>
> It's really hard to review this if you provide only minimal context.

I wanted to drop old EAPIS and reduce conditional branches to set EPREFIX=
and S=.
>
> I think you can drop multilib inherit for EAPI 6+.
>
> Any reason not to support EAPI 7?

Ah, I somwhow misunderstood ruby-fakegem or something is not supporting
EAPI 7... I will rewrite this series with EAPI 6 and 7 along with fixing
other bash style mistakes.

Thanks,

>
> --
> Best regards,
> Michał Górny
>