Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Alexis Ballier <aballier@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref
Date: Sat, 26 Sep 2015 15:37:33
Message-Id: 20150926173701.71f5946a.mgorny@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCHES] git-r3.eclass: Slight cleanup and support for any ref by Alexis Ballier
1 Dnia 2015-09-26, o godz. 16:44:14
2 Alexis Ballier <aballier@g.o> napisał(a):
3
4 > On Sat, 26 Sep 2015 15:28:56 +0200
5 > Michał Górny <mgorny@g.o> wrote:
6 >
7 > > Hi,
8 > >
9 > > Small patch set for review. Patch 1 cleans up some comments inside
10 > > the eclass, while patch 2 removes unused 'is_branch' variable.
11 > > Finally, patch 3 adds support for passing any of the 'refs/*' rather
12 > > than 'refs/heads/*' only. This was requested by vapier in #556822 [1].
13 >
14 > IMHO you don't need to send them for review here nor to create a
15 > branch for committing these, esp. the cosmetics part :)
16 >
17 > 3/3 will just increase what is fetched and might not break anything,
18 > right ?
19
20 I can't think of any case when it could break something.
21
22 --
23 Best regards,
24 Michał Górny
25 <http://dev.gentoo.org/~mgorny/>