1 |
On 18/07/13 10:25, Duncan wrote: |
2 |
> Justin posted on Thu, 18 Jul 2013 09:28:49 +0200 as excerpted: |
3 |
> |
4 |
>> + case ${EAPI:-0} in |
5 |
>> + 0|1|2|3) |
6 |
>> + eqawarn "The fortran-2.eclass is going to deprecate support |
7 |
> |
8 |
> ^^^^^^^^^^^ |
9 |
> |
10 |
> That reads strange to me. Deprecated doesn't mean it no longer works; it |
11 |
> means it's declared obsolete and recommended against but it still works |
12 |
> for now, thus giving users a time to migrate.[1] |
13 |
> |
14 |
> So "is going to deprecate" seems strange. It should be "has deprecated", |
15 |
> or rewording a bit more "support is deprecated for" or the like. Because |
16 |
> by the time someone's actually reading that output, the warning is |
17 |
> already there; the deprecation has already happened. |
18 |
> |
19 |
> Alternatively, keep the future tense and say "will be removed" or some |
20 |
> such, or use a hybrid, "support is deprecated and will be removed". |
21 |
> |
22 |
> --- |
23 |
> |
24 |
> [1] deprecate/deprecation online references: |
25 |
> http://en.wiktionary.org/wiki/deprecate |
26 |
> https://en.wikipedia.org/wiki/Deprecation |
27 |
> http://www.thefreedictionary.com/deprecate |
28 |
> http://www.google.com/search?q=define:deprecate |
29 |
> |
30 |
As long as there are only wording problems... |
31 |
|
32 |
|
33 |
|
34 |
Index: fortran-2.eclass |
35 |
=================================================================== |
36 |
RCS file: /var/cvsroot/gentoo-x86/eclass/fortran-2.eclass,v |
37 |
retrieving revision 1.18 |
38 |
diff -u -B -b -u -p -r1.18 fortran-2.eclass |
39 |
--- fortran-2.eclass 18 Jul 2013 07:03:33 -0000 1.18 |
40 |
+++ fortran-2.eclass 18 Jul 2013 08:42:56 -0000 |
41 |
@@ -203,11 +203,11 @@ _fortran_test_function() { |
42 |
fi |
43 |
} |
44 |
|
45 |
-# @FUNCTION: fortran-2_pkg_setup |
46 |
+# @FUNCTION: _fortran-2_pkg_setup |
47 |
+# @INTERNAL |
48 |
# @DESCRIPTION: |
49 |
-# Setup functionallity, |
50 |
-# checks for a valid fortran compiler and optionally for its openmp |
51 |
support. |
52 |
-fortran-2_pkg_setup() { |
53 |
+# _The_ fortran-2_pkg_setup() |
54 |
+_fortran-2_pkg_setup() { |
55 |
for _f_use in ${FORTRAN_NEEDED}; do |
56 |
case ${_f_use} in |
57 |
always) |
58 |
@@ -229,6 +229,27 @@ fortran-2_pkg_setup() { |
59 |
done |
60 |
} |
61 |
|
62 |
+ |
63 |
+# @FUNCTION: fortran-2_pkg_setup |
64 |
+# @DESCRIPTION: |
65 |
+# Setup functionallity, |
66 |
+# checks for a valid fortran compiler and optionally for its openmp |
67 |
support. |
68 |
+fortran-2_pkg_setup() { |
69 |
+ case ${EAPI:-0} in |
70 |
+ 0|1|2|3) |
71 |
+ eqawarn "Support for EAPI < 4 will be removed from the" |
72 |
+ eqawarn "fortran-2.eclass in near future." |
73 |
+ eqawarn "Please migrate your package to a higher EAPI" |
74 |
+ eqawarn "or file a bug at https://bugs.gentoo.org" |
75 |
+ _fortran-2_pkg_setup ;; |
76 |
+ 4|5) |
77 |
+ if [[ ${MERGE_TYPE} != binary ]]; then |
78 |
+ _fortran-2_pkg_setup |
79 |
+ fi |
80 |
+ ;; |
81 |
+ esac |
82 |
+} |
83 |
+ |
84 |
case ${EAPI:-0} in |
85 |
0|1|2|3|4|5) EXPORT_FUNCTIONS pkg_setup ;; |
86 |
*) die "EAPI=${EAPI} is not supported" ;; |