Gentoo Archives: gentoo-dev

From: Cyprien Nicolas <c.nicolas@×××××.com>
To: gentoo-dev@l.g.o
Cc: eva@g.o
Subject: Re: [gentoo-dev] eclass review for Gnome 2.32 and waf ebuilds
Date: Fri, 03 Dec 2010 20:55:09
Message-Id: AANLkTi=qmJ0Xp0_VkQrQ3Nq14D7zsDZKzjk36YCgbV3_@mail.gmail.com
In Reply to: [gentoo-dev] eclass review for Gnome 2.32 and waf ebuilds by Gilles Dartiguelongue
1 On Fri, Dec 3, 2010 at 21:25, Gilles Dartiguelongue <eva@g.o> wrote:
2 > Please also find in these patches a proposal of a waf-utils eclass in
3 > order to put waf related build management into an eclass. There is a
4 > couple of ebuilds already in tree all doing things on their own and I
5 > had a prototype laying around that I had to complete in order to have
6 > hamster-applet-2.32.
7
8 I took a look at the src_compile function from the proposed
9 waf-utils.eclass, and the sed expression you use is not correct, if
10 your objective is to filter everything but the -j/--jobs part of the
11 MAKEOPTS variable.
12 My current setting is MAKEOPTS="--jobs=3 --load-average=3.5", and it
13 is left unchanged by the current sed expression.
14
15 I had a issue with waf, with that MAKEOPTS thing [1]
16 Maybe you could take the expression referred in comment #3 [1], as
17 Samuli did, or maybe someone else have a better proposition.
18
19 1 https://bugs.gentoo.org/show_bug.cgi?id=335119
20
21 --
22 Cyprien Nicolas
23 Gentoo Lisp Project contributor
24 Fulax on #gentoo-lisp

Replies

Subject Author
Re: [gentoo-dev] eclass review for Gnome 2.32 and waf ebuilds Gilles Dartiguelongue <eva@g.o>