From: | Mike Gilbert <floppym@g.o> | ||
---|---|---|---|
To: | Gentoo Dev <gentoo-dev@l.g.o> | ||
Cc: | orbea <orbea@××××××.net> | ||
Subject: | [gentoo-dev] Re: [PATCH 2/5] meson.eclass: Support dev-util/samurai | ||
Date: | Mon, 09 May 2022 15:03:31 | ||
Message-Id: | CAJ0EP43aXXnchEmrOaiJrdb8Ku1kv6R-ABR0-Qr_yq-TdSEnCQ@mail.gmail.com | ||
In Reply to: | [gentoo-dev] [PATCH 2/5] meson.eclass: Support dev-util/samurai by Sam James |
1 | On Sun, May 8, 2022 at 7:07 PM Sam James <sam@g.o> wrote: |
2 | > |
3 | > From: orbea <orbea@××××××.net> |
4 | > |
5 | > samurai is a ninja-compatible build tool written in C which |
6 | > works with cmake, meson and other users of ninja. |
7 | > |
8 | > It is feature-complete and supports most of the same options |
9 | > as ninja. |
10 | |
11 | The patch looks fine, but the commit message doesn't describe the |
12 | change very well. It should probably mention something like "use |
13 | NINJA_DEPEND variable from ninja-utils.eclass". |