Gentoo Archives: gentoo-dev

From: Brian Evans <grknight@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] eclass: db-use - Update to eapi7-ver
Date: Mon, 27 Aug 2018 13:15:08
Message-Id: def0f028-98fd-1863-2aed-ae9634abd398@gentoo.org
In Reply to: [gentoo-dev] [PATCH] eclass: db-use - Update to eapi7-ver by Brian Evans
1 This is now committed with id 86416d2c4bf.
2
3 Brian
4
5 On 8/24/2018 1:28 PM, Brian Evans wrote:
6 > This is a very simple eclass which only calls these functions from eclasses:
7 > ver_cut (EAPI 0-6)
8 > get_libdir (EAPI 0-5)
9 > get_libname (ALL EAPI)
10 >
11 > I see no little reason to place die statements for unknown EAPIs.
12 > Just changing the eclasses to better suit the latest EAPI should be OK.
13 >
14 > Signed-off-by: Brian Evans <grknight@g.o>
15 > ---
16 > eclass/db-use.eclass | 10 +++++++---
17 > 1 file changed, 7 insertions(+), 3 deletions(-)
18 >
19 > diff --git a/eclass/db-use.eclass b/eclass/db-use.eclass
20 > index 35f11df034a..83ae94799ca 100644
21 > --- a/eclass/db-use.eclass
22 > +++ b/eclass/db-use.eclass
23 > @@ -1,10 +1,14 @@
24 > -# Copyright 1999-2014 Gentoo Foundation
25 > +# Copyright 1999-2018 Gentoo Foundation
26 > # Distributed under the terms of the GNU General Public License v2
27 > # This is a common location for functions that aid the use of sys-libs/db
28 > #
29 > # Bugs: maintainer-needed@g.o
30 >
31 > -inherit versionator multilib
32 > +# multilib is used for get_libname in all EAPI
33 > +case "${EAPI:-0}" in
34 > + 0|1|2|3|4|5|6) inherit eapi7-ver multilib ;;
35 > + *) inherit multilib ;;
36 > +esac
37 >
38 > #Convert a version to a db slot
39 > db_ver_to_slot() {
40 > @@ -38,7 +42,7 @@ db_findver() {
41 > fi
42 >
43 > PKG="$(best_version $1)"
44 > - VER="$(get_version_component_range 1-2 "${PKG/*db-/}")"
45 > + VER="$(ver_cut 1-2 "${PKG/*db-/}")"
46 > if [ -d "${EPREFIX}"/usr/include/db$(db_ver_to_slot "$VER") ]; then
47 > #einfo "Found db version ${VER}" >&2
48 > echo -n "$VER"
49 >

Attachments

File name MIME type
signature.asc application/pgp-signature