| 1 |
On Thu, 18 Aug 2011 14:38:01 +0400 |
| 2 |
Maxim Koltsov <maksbotan@g.o> wrote: |
| 3 |
|
| 4 |
> We've fixed all the problems with eclass. Please review it and give OK |
| 5 |
> for commit, i plan to do it this night. |
| 6 |
|
| 7 |
> 0|1) die "EAPI not supported, bug ebuild mantainer" ;; |
| 8 |
> *) die "Unknown EAPI, Bug eclass maintainers." ;; |
| 9 |
|
| 10 |
I think I already mentioned that. Keep consistent case, and in this |
| 11 |
case lowercase 'bug' is correct'. |
| 12 |
|
| 13 |
> # @ECLASS-VARIABLE: LC_PCAT |
| 14 |
> # @DESCRIPTION: |
| 15 |
> # Set this to the category of the plugin, if any. |
| 16 |
> : ${LC_PCAT:=} |
| 17 |
|
| 18 |
Please use verbose variable names, and prefix them with eclass |
| 19 |
filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY. |
| 20 |
|
| 21 |
And I think @DEFAULT_UNSET may be of interest too. |
| 22 |
|
| 23 |
> |
| 24 |
> if [ "${LC_PCAT+x}" != "x" ]; then |
| 25 |
> CMAKE_USE_DIR="${S}/src/plugins/${LC_PCAT}/${PN#leechcraft-}" |
| 26 |
> else |
| 27 |
> if [[ ${PN} != "leechcraft-core" ]]; then |
| 28 |
> CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}" |
| 29 |
> else |
| 30 |
> CMAKE_USE_DIR="${S}/src" |
| 31 |
> fi |
| 32 |
> fi |
| 33 |
|
| 34 |
if-elif-else-fi. |
| 35 |
|
| 36 |
And I think you dropped gentoo-dev@ from recipients a few mails ago. |
| 37 |
|
| 38 |
-- |
| 39 |
Best regards, |
| 40 |
Michał Górny |
Archives