Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.
Date: Mon, 14 Jan 2013 22:06:53
Message-Id: 201301141709.51771.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds. by Dan Douglas
1 On Monday 14 January 2013 12:55:29 Dan Douglas wrote:
2 > On Sunday, January 13, 2013 01:28:42 PM Mike Frysinger wrote:
3 > > On Sunday 13 January 2013 08:29:43 Michał Górny wrote:
4 > > > + [[ ${BUILD_DIR} ]] || die "${FUNCNAME}: BUILD_DIR not set."
5 > >
6 > > really should use -n there
7 >
8 > Doesn't matter. Only zsh requires it (and pointlessly disagrees with every
9 > other implementation).
10
11 the point wasn't "will it work". it's more "how easy is it to glance at code
12 and know what it is doing".
13 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies