Gentoo Archives: gentoo-dev

From:	Mike Gilbert <floppym@g.o>
To:	Gentoo Dev <gentoo-dev@l.g.o>
Cc:	Florian Schmaus <flow@g.o>
Subject:	Re: [gentoo-dev] [PATCH] java-vm-2.eclass: use "eselect java-vm update" if available
Date:	Mon, 27 Jun 2022 19:43:32
Message-Id:	`CAJ0EP43jpC3JMsb3U1fVuJCYRpOg8mbdbx+ttPop=vrTxtVthg@mail.gmail.com`
In Reply to:	Re: [gentoo-dev] [PATCH] java-vm-2.eclass: use "eselect java-vm update" if available by Georgy Yakovlev

1	On Mon, Jun 27, 2022 at 3:39 PM Georgy Yakovlev <gyakovlev@g.o> wrote:
2	>
3	> On Mon, 2022-06-27 at 21:21 +0200, Florian Schmaus wrote:
4	> > Thanks to Mike Gilbert (floppym) for valuable feedback.
5	> >
6	> > Closes: https://bugs.gentoo.org/853928
7	> > Closes: https://github.com/gentoo/gentoo/pull/26069
8	> > Signed-off-by: Florian Schmaus <flow@g.o>
9	> > ---
10	> > eclass/java-vm-2.eclass \| 30 ++++++++++++++++++++++++++++--
11	> > 1 file changed, 28 insertions(+), 2 deletions(-)
12	> >
13	> > diff --git a/eclass/java-vm-2.eclass b/eclass/java-vm-2.eclass
14	> > index 8196b1cdc72a..dc0d87f4caf5 100644
15	> > --- a/eclass/java-vm-2.eclass
16	> > +++ b/eclass/java-vm-2.eclass
17	> > @@ -25,6 +25,7 @@ RDEPEND="
18	> > "
19	> > DEPEND="${RDEPEND}"
20	> > BDEPEND="app-arch/unzip"
21	> > +IDEPEND="app-eselect/eselect-java"
22	>
23	> IDEPEND here will not do anything to current jdk source ebuilds.
24
25	I think that's fine. The eclass claims to support EAPI 8, so this will
26	make IDEPEND work properly if/when you update the JDK ebuilds.