Archives
Archives
| From: | "Michał Górny" <mgorny@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/2] check-reqs.eclass: Support EAPI-8 | ||
| Date: | Mon, 19 Jul 2021 06:04:04 | ||
| Message-Id: | 269156721c82cc700510eee779101dd2ab471ea7.camel@gentoo.org | ||
| In Reply to: | [gentoo-dev] [PATCH 1/2] check-reqs.eclass: Support EAPI-8 by Andreas Sturmlechner |
||
| 1 | On Sun, 2021-07-18 at 22:52 +0200, Andreas Sturmlechner wrote: |
| 2 | > Move EAPI check and EXPORT_FUNCTIONS on top, before include guard. |
| 3 | > Standardise include guard. |
| 4 | > |
| 5 | > Signed-off-by: Andreas Sturmlechner <asturm@g.o> |
| 6 | > --- |
| 7 | |
| 8 | While you're doing it: |
| 9 | |
| 10 | 1. Maybe add underscores prefix to internal functions and vars to avoid |
| 11 | confusion. |
| 12 | |
| 13 | 2. It's really time to retire I_KNOW_WHAT_I_AM_DOING in favor of |
| 14 | a dedicated variable. |
| 15 | |
| 16 | -- |
| 17 | Best regards, |
| 18 | Michał Górny |