Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o
Cc: leio@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-libs/gtk+: ChangeLog gtk+-2.12.0-r1.ebuild
Date: Tue, 25 Sep 2007 00:48:30
Message-Id: 20070925003704.GV22279@supernova
1 On 20:21 Mon 24 Sep , Mart Raudsepp (leio) wrote:
2 > leio 07/09/24 20:21:42
3 >
4 > Modified: ChangeLog
5 > Added: gtk+-2.12.0-r1.ebuild
6 > Log:
7 > Hopefully fix netscape-flash crashes and infinite loops and Java SWT tooltips weird behaviour and related crashes. Bug #193513 and part of bug #192310 and self-observation
8 > (Portage version: 2.1.3.9)
9
10 Numerous quoting issues for D and S
11
12 > 1.1 x11-libs/gtk+/gtk+-2.12.0-r1.ebuild
13 >
14 > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-libs/gtk+/gtk+-2.12.0-r1.ebuild?rev=1.1&view=markup
15 > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-libs/gtk+/gtk+-2.12.0-r1.ebuild?rev=1.1&content-type=text/plain
16
17 > pkg_setup() {
18 > if ! built_with_use x11-libs/cairo X; then
19 > einfo "Please re-emerge x11-libs/cairo with the X USE flag set"
20 > die "cairo needs the X flag set"
21 > fi
22 > }
23
24 One trick I like doing here is setting a local variable, then using it
25 twice to avoid duplicating the same info. For example:
26
27 local msg="Please re-emerge x11-libs/cairo with the X USE flag set"
28 eerror "$msg"
29 die "$msg"
30
31 BTW, note that I changed that einfo to an eerror, since it's dying.
32
33 > if [ -e /usr/lib/gtk-2.0/2.[^1]* ]; then
34 > elog "You need to rebuild ebuilds that installed into" /usr/lib/gtk-2.0/2.[^1]*
35 > elog "to do that you can use qfile from portage-utils:"
36 > elog "emerge -va1 \$(qfile -qC /usr/lib/gtk-2.0/2.[^1]*)"
37
38 Looks like get_libdir() should be here.
39
40 Thanks,
41 Donnie
42 --
43 gentoo-dev@g.o mailing list