| 1 |
On Wed, 10 Jul 2013 22:25:50 +0200 |
| 2 |
Michał Górny <mgorny@g.o> wrote: |
| 3 |
|
| 4 |
> First of all: please wrap lines at 72 or 80 chars (even if the |
| 5 |
> original eclass didn't do that). |
| 6 |
> |
| 7 |
> > if [[ "${CATEGORY}/${PN}" == "dev-python/twisted"* ]]; then |
| 8 |
> |
| 9 |
> I know you're not responsible for this but it seems wrong to have two |
| 10 |
> different behaviors depending on PN. Is this used somewhere actually? |
| 11 |
> |
| 12 |
> > MY_PV="${MY_PV:-${PV}}" |
| 13 |
> > MY_P="Twisted${MY_PACKAGE}-${MY_PV}" |
| 14 |
> > |
| 15 |
> > HOMEPAGE="http://www.twistedmatrix.com/" |
| 16 |
> > #SRC_URI="http://tmrc.mit.edu/mirror/twisted/${MY_PACKAGE}/$(get_version_component_range |
| 17 |
> > 1-2 ${MY_PV})/${MY_P}.tar.bz2" |
| 18 |
> > SRC_URI="http://twistedmatrix.com/Releases/${MY_PACKAGE}/$(get_version_component_range |
| 19 |
> > 1-2 ${MY_PV})/${MY_P}.tar.bz2" |
| 20 |
> > |
| 21 |
> > LICENSE="MIT" |
| 22 |
> > SLOT="0" |
| 23 |
> > IUSE="" |
| 24 |
> > |
| 25 |
> > S="${WORKDIR}/${MY_P}" |
| 26 |
> > |
| 27 |
> > TWISTED_PLUGINS="${TWISTED_PLUGINS:-twisted.plugins}" |
| 28 |
> > fi |
| 29 |
|
| 30 |
That's what I thought when I saw that but I found that all the |
| 31 |
dev-python/twisted-* packages are depending on this, so I went with it. |
| 32 |
|
| 33 |
Now I'm thinking I could instead provide functions |
| 34 |
twisted-r1_twisted_src_uri and twisted-r1_twisted_build_dir used as |
| 35 |
|
| 36 |
SRC_URI="$(twisted-r1_twisted_src_uri)" |
| 37 |
S="$(twisted-r1_twisted_build_dir)" |
| 38 |
|
| 39 |
in the depender ebuilds. |
Archives