Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | Alec Warner <antarus@g.o> | ||
| Cc: | Gentoo Dev <gentoo-dev@l.g.o> | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/2] eapi8-dosym.eclass: New eclass. | ||
| Date: | Thu, 19 Nov 2020 17:19:44 | ||
| Message-Id: | u3615463h@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] [PATCH 1/2] eapi8-dosym.eclass: New eclass. by Alec Warner |
||
| 1 | >>>>> On Thu, 19 Nov 2020, Alec Warner wrote: |
| 2 | |
| 3 | >> +_dosym8_canonicalize() { |
| 4 | |
| 5 | > in dosym8() you save and restore IFS, but you don't here, is there a reason |
| 6 | > for that? |
| 7 | |
| 8 | >> + local path slash i prev out IFS=/ |
| 9 | |
| 10 | IFS is a local variable, so its scope ends when the function returns. |
| 11 | We also don't call any other function from it, so we can get away |
| 12 | without save/restore. |
| 13 | |
| 14 | Ulrich |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |