| 1 |
On Thu, Aug 13, 2015 at 7:28 PM, Robin H. Johnson <robbat2@g.o> wrote: |
| 2 |
> On Thu, Aug 13, 2015 at 03:59:37PM -0400, Rich Freeman wrote: |
| 3 |
>> On Thu, Aug 13, 2015 at 3:43 PM, Robin H. Johnson <robbat2@g.o> wrote: |
| 4 |
>> > The intent is that the ONLY place the keywords are expanded, will be in |
| 5 |
>> > the rsync export. FUTURE tense, it's not ready yet. |
| 6 |
>> Will that include any case where the string "$Id$" appears in a patch file? |
| 7 |
> Those should be ripped out with extreme prejudice, ditto other |
| 8 |
> identifiers. |
| 9 |
> |
| 10 |
|
| 11 |
Seems like this should be a repoman warning at the very least, |
| 12 |
assuming we keep them at all. |
| 13 |
|
| 14 |
> |
| 15 |
>> That is the main source of problems here. |
| 16 |
>> |
| 17 |
>> Really, anytime what the dev tests and commits is different from what |
| 18 |
>> the users see is a potential source of problems. |
| 19 |
> If you want that, then you can expand it on your local systems. |
| 20 |
> |
| 21 |
|
| 22 |
The problem with this is that it depends on every dev doing something. |
| 23 |
|
| 24 |
The original purpose of this was so that people could tell if a file |
| 25 |
changes without it being revbumped? If so, rather than parsing an |
| 26 |
sha1 out of the file, why not just hash the file yourself? |
| 27 |
|
| 28 |
-- |
| 29 |
Rich |
Archives