Gentoo Archives: gentoo-dev

From: "Andreas K. Huettel" <dilfridge@g.o>
To: gentoo-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 07/15] perl-module.eclass: Do not do any magic with MY_... variables in EAPI=6 anymore
Date: Sat, 12 Dec 2015 20:26:31
Message-Id: 201512122126.15970.dilfridge@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 07/15] perl-module.eclass: Do not do any magic with MY_... variables in EAPI=6 anymore by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 Am Samstag, 12. Dezember 2015, 12:59:08 schrieb Michał Górny:
5 > Dnia 11 grudnia 2015 22:03:03 CET, dilfridge@g.o napisał(a):
6 > >
7 > >-if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} ]] ; then
8 > >- : ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV}}}}
9 > >- S=${MY_S:-${WORKDIR}/${MY_P}}
10 > >+if [[ ${EAPI:-0} = 5 ]] ; then
11 > >+ if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} ]] ; then
12 > >+ : ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV}}}}
13 > >+ S=${MY_S:-${WORKDIR}/${MY_P}}
14 > >+ fi
15 > >+ MODULE_NAME=${MY_PN:-${PN}}
16 > >+ MODULE_P=${MY_P:-${P}}
17 > >+else
18 > >+ MODULE_NAME=${MODULE_NAME:-${PN}}
19 > >+ MODULE_P=${MODULE_NAME}-${MODULE_VERSION:-${PV}}
20 > >+ S=${WORKDIR}/${MODULE_P}
21
22 > How likely is it that one would use MY_* without MODULE_*? Maybe it would
23 > be good to warn about this?
24
25 Well... the main usage of this input is calculation of SRC_URI and S.
26
27 So, I'm not so worried about it, since failing to update the settings will
28 lead to problems already when running ebuild manifest...
29
30 - --
31
32 Andreas K. Huettel
33 Gentoo Linux developer
34 dilfridge@g.o
35 http://www.akhuettel.de/
36
37 -----BEGIN PGP SIGNATURE-----
38 Version: GnuPG v2.1
39
40 iQJ8BAEBCgBmBQJWbILnXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
41 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0RkJDMzI0NjNBOTIwMDY5MTQ2NkMzNDBF
42 MTM4NkZEN0VGNEI1Nzc5AAoJEOE4b9fvS1d5G+MQALIzMM1eedqHJJeLCd9wA1NB
43 0I9usDqNFv1XOUA0cMEpPMSSqpmEx5/rCBdTAwjOYhqzf1U7ks9ZPPaVwxNFTqR+
44 t1eoOtT2w9JbJzeBfWOefiwBwhAVKZH56mH5oITDzN+QWev7n2Xs336fSN1P6glW
45 Ip4JqKNXH7fbV0jvmID6Yc6iReXXGLKs862us6cDpkm03bq4c1SE4dgWNN69UCkv
46 oM5DfP3PqNkOXLWafNGpvgD0NCdzm64bDZo+/8OlmZ1rFNDp0pAuDUyblWCMuGZw
47 mvTetAES0u5F1TyOA4x2jK+CGHvonnBorCBaTvSjLiNtBZ/b/KatrGYqwn0/yHo7
48 Hoz3Vq9ZgcKnT9asKv2sJOLG8V1rjVTcJJrJKrhj6MziWikhFblxfktnc0MO1//1
49 DWPpj9kbO7H33gZ7Ob3fegdk7BJzhcKxoTTRwKixXpGcwpR+KZ98z7YvqCDZwJq3
50 RTKrsM9FgTmqPgMxkR+/8XLrJrEKDR8UfSUgp10fdXLgEVX/6fY5mmSUc5SOqfOV
51 HjpZAo5ioJ1lyETQisWIC4VTBYIlBvgWrkbqUPM5gh7lOk0Gd+NR3/8es1BMA0h/
52 68WpyJ1z2m57bnmseD/WXBwU81xp52teM0rWGrB+c0JvEtAQ2YB3Xq6UCxDcjuxs
53 nu83ET+yxh4A9ptmaJHb
54 =7sm6
55 -----END PGP SIGNATURE-----