Re: [gentoo-dev] [RFC] obs eclasses

[Michal Hrusecky]

Amadeusz Żołnowski - 13:24 13.09.11 wrote:
> Hi,
>
>
> Excerpts from Michal Hrusecky's message of 2011-09-13 13:11:28 +0200:
> > Comments and improvements are welcome.
>
> Just some minor remarks:
>
>
> > [[ -z ${OPENSUSE_RELEASE} ]] || OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}"
> > [[ -n ${OBS_PROJECT} ]]      || die "OBS_PROJECT not set!"
> > [[ -n ${OBS_PACKAGE} ]]      || die "OBS_PACKAGE not set!"
>
> You don't need -n/-z with [[.

But they don't do any harm either, right ;-)

>   [[ $var ]] == [[ -n $var ]]
>   [[ ! $var ]] == [[ -z $var ]]
>
> So:
>
>   [[ ${OPENSUSE_RELEASE} ]] && OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}"
>   [[ ${OBS_PROJECT} ]] || die "OBS_PROJECT not set!"
>   [[ ${OBS_PACKAGE} ]] || die "OBS_PACKAGE not set!"
>
> > obs-service_src_install() {
> >         debug-print-function ${FUNCNAME} "$@"
> >         debug-print "Installing service \"${OBS_SERVICE_NAME}\""
> >         exeinto /usr/lib/obs/service
> >         doexe ${DISTDIR}/${OBS_SERVICE_NAME}
> >         insinto /usr/lib/obs/service
> >         doins ${DISTDIR}/${OBS_SERVICE_NAME}.service
> >         if [[ -n ${ADDITIONAL_FILES} ]]; then
> >                 debug-print "Installing following additional files:"
> >                 debug-print "        ${ADDITIONAL_FILES}"
> >                 exeinto /usr/lib/obs/service/${OBS_SERVICE_NAME}.files
> >                 for i in ${ADDITIONAL_FILES}; do
> >                         doexe ${DISTDIR}/$i
>
> "" just in case.

Fixed.

-- 
	Michal Hrusecky <miska@g.o>