1 |
On 05/21/2012 12:04 PM, Pacho Ramos wrote: |
2 |
> El lun, 21-05-2012 a las 13:46 -0400, Alexandre Rostovtsev escribió: |
3 |
>> On May 20, autools.eclass was changed to no longer inherit eutils, see |
4 |
>> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134 |
5 |
>> |
6 |
>> Relying on autotools.eclass for your eutils needs was always a terrible |
7 |
>> idea, but a few ebuilds did it anyway. Those ebuilds are now *broken* |
8 |
>> since they can no longer use epatch. See bug #416847 for an example. |
9 |
>> |
10 |
>> Check your ebuilds to make sure you inherit eutils in anything that uses |
11 |
>> epatch! |
12 |
>> |
13 |
>> -Alexandre Rostovtsev. |
14 |
>> |
15 |
>> |
16 |
>> |
17 |
> |
18 |
> Looks like ebuilds not inheriting eutils directly even using epatch are |
19 |
> a lot as I have seen running: |
20 |
> grep inherit $(grep -r epatch */*/*.ebuild| cut -d: -f1) | grep -v |
21 |
> eutils |
22 |
> |
23 |
> Maybe they should be checked and a repoman warning should be added when |
24 |
> an ebuild is using epatch without inheriting eutils directly, otherwise |
25 |
> this problem could reappear if some other eclass no longer inherit it in |
26 |
> the future :-/ |
27 |
|
28 |
Yeah, we have a similar check for inherit of prefix.eclass: |
29 |
|
30 |
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b583812101f1156c553385effcd9dbee0b751087 |
31 |
-- |
32 |
Thanks, |
33 |
Zac |