Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Alice Ferrazzi <alicef@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] Clean deblob
Date: Thu, 26 Aug 2021 08:59:55
Message-Id: uwno8y41v@gentoo.org
In Reply to: [gentoo-dev] [PATCH] Clean deblob by Alice Ferrazzi
1 >>>>> On Thu, 26 Aug 2021, Alice Ferrazzi wrote:
2
3 > As we are moving out to deprecate EAPI=6 from kernel-2.eclass
4 > start removing it from deblob function. Also clean code linked to old
5 > kernel versions. kernel sources that use deblob are already updated to
6 > EAPI=8
7
8 Somewhat unrelated, since I see calls to kernel_is() in your patch:
9
10 That function has a horrible hack for version comparison:
11
12 : $(( test = (KV_MAJOR << 16) + (KV_MINOR << 8) + KV_PATCH ))
13 : $(( value = (${1:-${KV_MAJOR}} << 16) + (${2:-${KV_MINOR}} << 8) + ${3:-${KV_PATCH}} ))
14 [ ${test} ${operator} ${value} ]
15
16 There are versions like gentoo-sources-4.9.280, so the shift by 8 may
17 cause surprising results.
18
19 I'll send a patch later.
20
21 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature