Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o, iluxa@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-cpp/sptk: ChangeLog sptk-3.5.8.9.ebuild
Date: Mon, 19 Jan 2009 17:38:03
Message-Id: 20090119173759.GB4552@hermes
1 On 11:11 Mon 19 Jan , Ilya Volynets (iluxa) wrote:
2 > 1.1 dev-cpp/sptk/sptk-3.5.8.9.ebuild
3 >
4 > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-cpp/sptk/sptk-3.5.8.9.ebuild?rev=1.1&view=markup
5 > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-cpp/sptk/sptk-3.5.8.9.ebuild?rev=1.1&content-type=text/plain
6
7 > LICENSE="|| ( BSD )"
8
9 What's going on here? Looks like an alternate license might've been
10 dropped.
11
12 > check_use() {
13 > if use ${1}; then
14 > SPTK_OPTIONS="${SPTK_OPTIONS} -DNO_${2}:BOOLEAN=FALSE"
15 > else
16 > SPTK_OPTIONS="${SPTK_OPTIONS} -DNO_${2}:BOOLEAN=TRUE"
17 > fi
18 > }
19
20 I would rename or rewrite this function. It's not just checking and
21 returning 0 or 1 as the name implies -- it's setting a global variable.
22
23 > src_install () {
24 >
25 > make DESTDIR="${D}" install || die "Installation failed"
26
27 emake, please. With -j1 and a comment pointing to the upstream bug if it
28 fails.
29
30 > dodir /usr/share/doc/${PF}
31 > cp -r "${S}"/docs/* "${D}"/usr/share/doc/${PF}
32 > if use doc; then
33 > rm -fr "${D}/usr/share/doc/${PF}/latex"
34 > cp -rf "${S}/pictures" "${D}/usr/share/doc/${PF}"
35 > fi
36
37 Does this need a prepalldocs or does that happen automatically? I'm not
38 on a Gentoo system atm to check.
39
40 --
41 Thanks,
42 Donnie
43
44 Donnie Berkholz
45 Developer, Gentoo Linux
46 Blog: http://dberkholz.wordpress.com