Gentoo Archives: gentoo-dev

From: Tom Wijsman <TomWij@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH systemd.eclass] Introduce systemd_is_booted().
Date: Wed, 24 Jul 2013 08:32:25
Message-Id: 20130724102828.65d63528@TOMWIJ-GENTOO
In Reply to: [gentoo-dev] [PATCH systemd.eclass] Introduce systemd_is_booted(). by "Michał Górny"
1 On Wed, 24 Jul 2013 09:18:13 +0200
2 Michał Górny <mgorny@g.o> wrote:
3
4 > Pacho requested that to be able to warn users in GNOME packages that
5 > do not work anymore without systemd.
6 >
7 > +# @FUNCTION: systemd_is_booted
8 > +# @DESCRIPTION:
9 > +# Check whether the system was booted using systemd.
10
11 Can we have a short mention of that kind of usage in the description?
12
13 There is some set of possible wrong usages, some of which are nasty,
14 that this function should not be used for; for example, someone could
15 use this as a check to install a file which I believe isn't permitted.
16
17 Are there even other legit usages your original function would permit?
18
19 Alternatively, you could change the function altogether into something
20 more specific; eg. ewarn_systemd_boot and ewarn_no_systemd_boot.
21
22 These functions would then take a message as parameter; then the
23 resulting behavior of this function is in your hands, not the consumer.
24
25 --
26 With kind regards,
27
28 Tom Wijsman (TomWij)
29 Gentoo Developer
30
31 E-mail address : TomWij@g.o
32 GPG Public Key : 6D34E57D
33 GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D

Attachments

File name MIME type
signature.asc application/pgp-signature