1 |
On Tuesday 19 June 2012 22:46:26 Samuli Suominen wrote: |
2 |
> On 06/15/2012 06:10 PM, Mike Frysinger wrote: |
3 |
> > On Friday 15 June 2012 03:44:14 Samuli Suominen wrote: |
4 |
> >> On 06/13/2012 06:02 AM, Mike Frysinger wrote: |
5 |
> >>> i've noticed a growing trend where people put setup of variables into |
6 |
> >>> pkg_setup that only matter to src_* funcs presumably so they don't have |
7 |
> >>> to call the respective src_* func from an inherited eclass. |
8 |
> >>> unfortunately this adds pointless overhead to binpkgs. can we please |
9 |
> >>> move away from this practice ? |
10 |
> >> |
11 |
> >> Every Xfce ebuild in gentoo-x86 is using pkg_setup() for 3 variables, |
12 |
> >> DOCS for src_install, PATCHES for src_prepare |
13 |
> > |
14 |
> > these are static variables, so defining them in a func is pointless |
15 |
> |
16 |
> "sort of" not necessarily, 'has $useflag && PATCHES+=( )' has been used |
17 |
> before, not sure if it's used in tree right now or not |
18 |
|
19 |
as we've always said, USE conditional patches are to be highly discouraged |
20 |
|
21 |
> >> and XFCONF for src_configure |
22 |
> > |
23 |
> > now you're down to one variable which means you've got one func to |
24 |
> > /properly/ define |
25 |
> |
26 |
> src_configure() still requires calling itself (xfconf_src_configure) in |
27 |
> the end of the function |
28 |
|
29 |
yes, but that's the correct way to do it |
30 |
-mike |