From: | Samuli Suominen <ssuominen@g.o> |
---|---|
To: | gentoo-dev@l.g.o, chainsaw@g.o |
Subject: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/dynamips/files: dynamips-0.2.8_rc2-makefile.patch |
Date: | Sun, 17 Oct 2010 13:43:53 |
Message-Id: | 4CBAFEBC.5090402@gentoo.org |
1 | On 10/17/2010 03:58 PM, Tony Vroon (chainsaw) wrote: |
2 | > chainsaw 10/10/17 12:58:02 |
3 | > |
4 | > Modified: dynamips-0.2.8_rc2-makefile.patch |
5 | > Log: |
6 | > Instill LDFLAGS respect into upstream Makefile. Closes bug #338169 by Diego Elio "Flameeyes" Pettenò. |
7 | > |
8 | > (Portage version: 2.1.9.19/cvs/Linux x86_64) |
9 | > |
10 | > Revision Changes Path |
11 | > 1.2 app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch |
12 | > |
13 | > file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch?rev=1.2&view=markup |
14 | > plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch?rev=1.2&content-type=text/plain |
15 | > diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch?r1=1.1&r2=1.2 |
16 | > |
17 | > Index: dynamips-0.2.8_rc2-makefile.patch |
18 | > =================================================================== |
19 | > RCS file: /var/cvsroot/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch,v |
20 | > retrieving revision 1.1 |
21 | > retrieving revision 1.2 |
22 | > diff -u -r1.1 -r1.2 |
23 | > --- dynamips-0.2.8_rc2-makefile.patch 7 Aug 2009 16:40:38 -0000 1.1 |
24 | > +++ dynamips-0.2.8_rc2-makefile.patch 17 Oct 2010 12:58:02 -0000 1.2 |
25 | > @@ -1,6 +1,6 @@ |
26 | > -diff -uNr dynamips-0.2.8-RC2.ORIG/Makefile dynamips-0.2.8-RC2/Makefile |
27 | > ---- dynamips-0.2.8-RC2.ORIG/Makefile 2009-08-07 17:24:11.000000000 +0100 |
28 | > -+++ dynamips-0.2.8-RC2/Makefile 2009-08-07 17:24:52.000000000 +0100 |
29 | > ++ @$(CC) -o $@ $(C_OBJS) $(A_OBJS) $(LIBS) $(LDFLAGS) |
30 | > ++ @$(CC) -Wall $(CFLAGS) -o $@ nvram_export.c $(LDFLAGS) |
31 | |
32 | That doesn't work. LDFLAGS need to come before objects/libraries so |
33 | -Wl,--as-needed is effective. That will only silently make the QA |
34 | warning from Portage go away, but is still wrong. |
35 | Should be right after CC instead: |
36 | |
37 | $(CC) $(LDFLAGS) ... |
Subject | Author |
---|---|
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/dynamips/files: dynamips-0.2.8_rc2-makefile.patch | "Tony \\\"Chainsaw\\\" Vroon" <chainsaw@g.o> |