| 1 |
On 21:03 Fri 16 Jan , Peter Alfredsen wrote: |
| 2 |
> NO_MONO_DEPEND=( |
| 3 |
> "dev-lang/mono" |
| 4 |
> "dev-dotnet/libgdiplus" |
| 5 |
> "dev-dotnet/gluezilla" |
| 6 |
> ) |
| 7 |
|
| 8 |
I'm not a huge fan of having package-specific logic in eclasses. This |
| 9 |
would be nicer to see as a variable set in the packages like |
| 10 |
MONO_DEPEND="no". That would also get rid of the double-negative logic |
| 11 |
below: |
| 12 |
|
| 13 |
> if ! has "${CATEGORY}/${PN}" "${NO_MONO_DEPEND[@]}" |
| 14 |
> then |
| 15 |
> RDEPEND="=dev-lang/mono-${GO_MONO_REL_PV}*" |
| 16 |
> DEPEND="${RDEPEND}" |
| 17 |
> fi |
| 18 |
|
| 19 |
|
| 20 |
> if [[ "${PV%_rc*}" != "${PV}" ]] |
| 21 |
> then |
| 22 |
> GO_MONO_P="${P%_rc*}" |
| 23 |
> SRC_URI="${PRE_URI}/${PN}/${GO_MONO_P} -> ${P}.tar.bz2" |
| 24 |
> S="${WORKDIR}/${GO_MONO_P}" |
| 25 |
> elif [[ "${PV%_pre*}" != "${PV}" ]] |
| 26 |
> then |
| 27 |
> GO_MONO_P="${P%_pre*}" |
| 28 |
> SRC_URI="${PRE_URI}/${PN}/${GO_MONO_P} -> ${P}.tar.bz2" |
| 29 |
> S="${WORKDIR}/${GO_MONO_P}" |
| 30 |
> else |
| 31 |
> GO_MONO_P=${P} |
| 32 |
> SRC_URI="http://ftp.novell.com/pub/mono/sources/${PN}/${P}.tar.bz2" |
| 33 |
> fi |
| 34 |
|
| 35 |
How about GO_MONO_P=${P%_[a-z]*} -- doesn't that work in all cases? |
| 36 |
|
| 37 |
-- |
| 38 |
Thanks, |
| 39 |
Donnie |
| 40 |
|
| 41 |
Donnie Berkholz |
| 42 |
Developer, Gentoo Linux |
| 43 |
Blog: http://dberkholz.wordpress.com |
Archives