| 1 |
On Sat, 9 Mar 2013 18:50:36 +0100 |
| 2 |
Michał Górny <mgorny@g.o> wrote: |
| 3 |
|
| 4 |
> On Sat, 09 Mar 2013 19:26:34 +0200 |
| 5 |
> Samuli Suominen <ssuominen@g.o> wrote: |
| 6 |
> |
| 7 |
> > I have to run off for few hours, like now, but this one user is filing |
| 8 |
> > dozens of these epunt_cxx bugs and nobody seem to be able to reproduce them: |
| 9 |
> > |
| 10 |
> > http://tinyurl.com/bjwxzad |
| 11 |
> > |
| 12 |
> > Could someone verify they are actually legimate before they get assigned |
| 13 |
> > to maintainers? |
| 14 |
> |
| 15 |
> Oh, I see the problem now. Stupid bash, stupid loops and stupid |
| 16 |
> subshelling. I'll attach a patch for the check in a minute. |
| 17 |
|
| 18 |
Index: eutils.eclass |
| 19 |
=================================================================== |
| 20 |
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v |
| 21 |
retrieving revision 1.411 |
| 22 |
diff -u -B -r1.411 eutils.eclass |
| 23 |
--- eutils.eclass 26 Feb 2013 14:36:40 -0000 1.411 |
| 24 |
+++ eutils.eclass 9 Mar 2013 17:54:20 -0000 |
| 25 |
@@ -1270,11 +1270,11 @@ |
| 26 |
[[ -z ${dir} ]] && dir=${S} |
| 27 |
ebegin "Removing useless C++ checks" |
| 28 |
local f any_found |
| 29 |
- find "${dir}" -name configure | while read f ; do |
| 30 |
+ while IFS= read -r -d '' f; do |
| 31 |
patch --no-backup-if-mismatch -p0 "${f}" \ |
| 32 |
"${PORTDIR}/eclass/ELT-patches/nocxx/nocxx.patch" > /dev/null \ |
| 33 |
&& any_found=1 |
| 34 |
- done |
| 35 |
+ done < <(find "${dir}" -name configure -print0) |
| 36 |
|
| 37 |
if [[ -z ${any_found} ]]; then |
| 38 |
eqawarn "epunt_cxx called unnecessarily (no C++ checks to punt)." |
| 39 |
|
| 40 |
----- |
| 41 |
But that doesn't seem to be the issue. If you remove '>/dev/null', |
| 42 |
you'd notice that the patch does not apply... |
| 43 |
|
| 44 |
-- |
| 45 |
Best regards, |
| 46 |
Michał Górny |
Archives