Re: [gentoo-dev] [PATCH 2/3] perl-functions.eclass: Add new helpers for EAPI=8 ...

[Michał Górny]

On Sat, 2021-06-19 at 13:01 +0200, dilfridge@g.o wrote:
> From: Andreas K. Hüttel <dilfridge@g.o>
>
> ... and fix an existing one.
>
> fperms works on ${D} by default, so we can give it / to operate on.
>
> Bug: https://bugs.gentoo.org/554346
> Bug: https://bugs.gentoo.org/733020
> Signed-off-by: Andreas K. Hüttel <dilfridge@g.o>
> ---
>  eclass/perl-functions.eclass | 35 ++++++++++++++++++++++++++++++++---
>  1 file changed, 32 insertions(+), 3 deletions(-)
>
> diff --git a/eclass/perl-functions.eclass b/eclass/perl-functions.eclass
> index 8633f384f1bf..d0a082797265 100644
> --- a/eclass/perl-functions.eclass
> +++ b/eclass/perl-functions.eclass
> @@ -8,7 +8,7 @@
>  # Seemant Kulleen <seemant@g.o>
>  # Andreas K. Huettel <dilfridge@g.o>
>  # Kent Fredric <kentnl@g.o>
> -# @SUPPORTED_EAPIS: 5 6 7
> +# @SUPPORTED_EAPIS: 5 6 7 8
>  # @BLURB: helper functions eclass for perl modules
>  # @DESCRIPTION:
>  # The perl-functions eclass is designed to allow easier installation of perl
> @@ -19,7 +19,7 @@
>  [[ ${CATEGORY} == "perl-core" ]] && inherit alternatives
>
>  case "${EAPI:-0}" in
> -	5|6|7)
> +	5|6|7|8)
>  		;;
>  	*)
>  		die "EAPI=${EAPI} is not supported by perl-functions.eclass"
> @@ -134,7 +134,8 @@ perl_delete_emptybsdir() {
>  perl_fix_permissions() {
>  	debug-print-function $FUNCNAME "$@"
>  	perl_set_version
> -	fperms -R u+w "${D}"
> +	einfo Fixing installed file permissions
> +	fperms -R u+w /
>  }
>
>  # @FUNCTION: perl_fix_packlist
> @@ -596,3 +597,31 @@ perl_domodule() {
>  	insinto "/${target#/}"
>  	doins "${doins_opts[@]}" "${files[@]}"
>  }
> +
> +# @FUNCTION: perl_get_wikiurl
> +# @DESCRIPTION:
> +# Convenience helper for returning the Gentoo Wiki maintenance page URL of a
> +# package. Optionally a suffix can be passed for an in-page anchor.
> +#
> +# Example:
> +# @CODE
> +# my_url="$(perl_get_wikiurl Testing)"
> +# @CODE
> +
> +perl_get_wikiurl() {
> +	debug-print-function $FUNCNAME "$@"
> +
> +	if [[ "" == ${1} ]]; then

[[ -z ${1} ]] ? ;-)

> +		echo "https://wiki.gentoo.org/wiki/Project:Perl/maint-notes/${CATEGORY}/${PN}"
> +	else
> +		echo "https://wiki.gentoo.org/wiki/Project:Perl/maint-notes/${CATEGORY}/${PN}#${1}"
> +	fi
> +}
> +
> +perl_get_wikiurl_features() {
> +	perl_get_wikiurl Optional_Features
> +}
> +
> +perl_get_wikiurl_tests() {
> +	perl_get_wikiurl Testing
> +}

-- 
Best regards,
Michał Górny