Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: multilib@g.o, "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 3/3] Deprecate multilib_for_best_abi().
Date: Mon, 05 May 2014 08:31:02
Message-Id: 1399278606-7549-3-git-send-email-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi() by "Michał Górny"
1 This was planned for a while. The concept of 'best' and 'native' that
2 are not always the same ABI is confusing and mostly unnecessary.
3 Additionally, we prefer people using multilib-minimal phases rather than
4 multilib_for* functions.
5 ---
6 eclass/multilib-build.eclass | 3 +++
7 1 file changed, 3 insertions(+)
8
9 diff --git a/eclass/multilib-build.eclass b/eclass/multilib-build.eclass
10 index 4a87af6..de6c27b 100644
11 --- a/eclass/multilib-build.eclass
12 +++ b/eclass/multilib-build.eclass
13 @@ -210,6 +210,9 @@ multilib_parallel_foreach_abi() {
14 multilib_for_best_abi() {
15 debug-print-function ${FUNCNAME} "${@}"
16
17 + eqawarn "QA warning: multilib_for_best_abi() function is deprecated and should"
18 + eqawarn "not be used. The multilib_is_native_abi() check may be used instead."
19 +
20 local MULTIBUILD_VARIANTS=( $(multilib_get_enabled_abi_pairs) )
21
22 multibuild_for_best_variant _multilib_multibuild_wrapper "${@}"
23 --
24 1.9.2

Replies