Re: [gentoo-dev] New version of heroes ebuild

[Dan Armak]

On Monday 09 July 2001 18:54, you wrote:
> On Mon, Jul 09, 2001 at 02:19:59PM +0300, Dan Armak wrote:
> > The original version I posted installed a file into /doc: a very strange
> > default on the part of the makefile. The ebuild now passes a special
> > paramter to configure to make it install into /usr/share/doc/${P} as
> > needed.
> >
> > DEPEND="virtual/x11"
> >
> > if [ "`use sdl`" ]; then
> >     DEPEND="${DEPEND} media-libs/libsdl media-libs/sdl-mixer"
> >     confopts="${confopts} --with-sdl --with-sdl-mixer"
> > else # `use ggi` isn't checked since this is the game's default
> >     DEPEND="${DEPEND} media-libs/libggi media-libs/libgii
> > 	    media-libs/libmikmod"
> >     confopts="${confopts} --with-ggi --with-mikmod"
> > fi
> >
> > DEPEND="media-libs/libsdl media-libs/sdl-mixer virtual/x11"
>
> OK, some notes.  First, notice that you just overwrote your DEPEND settings
> with this line above, so any DEPEND tweaking you did previously was lost.
> Did you mean to use RDEPEND instead?  If so, it defaults to be the same a
> DEPEND if not defined.

Terribly sorry! - my mistake. This is a line I thought I'd deleted or 
commented out. You should just delete it. Then it will be OK.

>
> Next, you can use our handy DEPEND/RDEPEND syntax to do stuff like this:
>
> DEPEND="virtual/x11 sdl? ( media-libs/libsdl media-libs/sdl-mixer ) ggi? (
> media-libs/libggi media-libs/libgii )"
>

Yes but: if the game needs either SDl of libGGI, this syntax doesn't make 
sure at least something is defined in DEPEND. If neither USE variable is set, 
niether lib will be installed and the game won't compile as it needs at least 
1 frontend lib.

> Also, it may not be good to use sdl *or* libggi.  Can one compile-in both
> options?  If not, then the best approach (taking into account the current
> functionality of the ebuild system) is to create two packages: heroes-sdl
> and heroes-ggi.  Right now, there's no good way for Portage to choose
> between two existing USE variables; ie. if ggi and sdl are defined, Portage
> has no way of knowing which one should be preferred.
>

Yes but: the heroes game developers themselves prefer SDL over GGI. This is 
because it is better maintained. (according to the readme file).
And no, you can't compile both options. Unless you patch the Makefile to 
compile 2 different executables. But in that case it's better to make 2 
diferent ebuilds - however, they will be mutually exclusive. But it's easy 
enough to separate into heroes-ggi and heroes-sdl. Do that if you think 
that's what's needed. 

> > src_unpack() {
> >
> >     unpack ${A1} ${A2} ${A3} ${A4}
> >
> > }
>
> The default src_unpack function should perform this step for you, so you
> should be able to remove the src_unpack() function from your ebuild. Also,
> the preferred way of doing things now is to remove the A= definition from
> your ebuild and just use SRC_URI:

I wasn't sure about that.

>
> SRC_URI="http://prdownloads.sourceforge.net/heroes/heroes-0.11.tar.gz
> http://prdownloads.sourceforge.net/heroes/heroes-data-1.1.tar.gz
> http://prdownloads.sourceforge.net/heroes/heroes-sound-tracks-1.0.tar.gz
> http://prdownloads.sourceforge.net/heroes/heroes-sound-effects-1.0.tar.gz"
>
> Other than that, it looks good and I look forward to playing it soon! :)

OK. I'll learn from my mistakes :-)


Dan