| 1 |
On Sun, May 30, 2021 at 01:29:12PM -0400, mpagano@g.o wrote: |
| 2 |
> From: Mike Pagano <mpagano@g.o> |
| 3 |
> |
| 4 |
> As the purpose of pkg_pretend is to run sanity checks during |
| 5 |
> dependency calculation time, provide the default implementation |
| 6 |
> and perform CONFIG_CHECK within it. |
| 7 |
> |
| 8 |
> See bug #759238 |
| 9 |
> |
| 10 |
[...] |
| 11 |
> |
| 12 |
> +# @FUNCTION: linux-mod_pkg_pretend |
| 13 |
> +# @DESCRIPTION: |
| 14 |
> +# Check the CONFIG_CHECK options |
| 15 |
> +linux-mod_pkg_pretend() { |
| 16 |
> + |
| 17 |
> + debug-print-function ${FUNCNAME} $* |
| 18 |
> + # External modules use kernel symbols (bug #591832, #759238) |
| 19 |
> + CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS" |
| 20 |
> +} |
| 21 |
|
| 22 |
Is this not supposed to actually run the checks? Correct me if I'm |
| 23 |
missing something but it's just setting the value. linux-mod normally |
| 24 |
run the checks through linux-info_pkg_setup and its check_extra_config. |
| 25 |
|
| 26 |
For nvidia-drivers, this value will also be lost for the pkg_setup test |
| 27 |
(needed to check, say.. gentoo-kernel emerged in-between) because I |
| 28 |
currently set a local CONFIG_CHECK="..." inside pkg_setup() |
| 29 |
(there's also a conditional CONFIG_CHECK, part of why not global) |
| 30 |
|
| 31 |
Some other ebuilds set CONFIG_CHECK in pkg_setup I believe. |
| 32 |
|
| 33 |
Not that I can't change this for nvidia, I guess I could set a global |
| 34 |
scope CONFIG_CHECK with !FATAL-only and += the non-fatal ones in |
| 35 |
pkg_setup to avoid message duplication. |
| 36 |
|
| 37 |
Have same concerns as mgorny wrt exported pkg_pretend, plus I'd also |
| 38 |
need to add my own pkg_pretend wrapper to check MODULES_OPTIONAL_USE |
| 39 |
-- |
| 40 |
ionen |
Archives