Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 6/6] virtualx.eclass: Do not disable sandbox
Date: Wed, 27 Jul 2022 07:19:29
Message-Id: 20220727071722.277530-7-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 0/6] virtualx.eclass: Use Xvfb -displayfd ... + cleanup by "Michał Górny"
1 The code responsible for disabling sandbox dates back to 2002 and does
2 not include any explanation. Let's try if we still need it.
3
4 Signed-off-by: Michał Górny <mgorny@g.o>
5 ---
6 eclass/virtualx.eclass | 7 -------
7 1 file changed, 7 deletions(-)
8
9 diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
10 index c0af095e89a5..e04834d39bd1 100644
11 --- a/eclass/virtualx.eclass
12 +++ b/eclass/virtualx.eclass
13 @@ -107,7 +107,6 @@ virtx() {
14
15 local i=0
16 local retval=0
17 - local OLD_SANDBOX_ON="${SANDBOX_ON}"
18 local xvfbargs=( -screen 0 1280x1024x24 +extension RANDR )
19
20 debug-print "${FUNCNAME}: running Xvfb hack"
21 @@ -115,9 +114,6 @@ virtx() {
22
23 einfo "Starting Xvfb ..."
24
25 - # We really do not want SANDBOX enabled here
26 - export SANDBOX_ON="0"
27 -
28 debug-print "${FUNCNAME}: Xvfb -displayfd 1 ${xvfbargs[*]}"
29 local logfile=${T}/Xvfb.log
30 local pidfile=${T}/Xvfb.pid
31 @@ -134,9 +130,6 @@ virtx() {
32 die "Xvfb failed to start"
33 fi
34
35 - # Now enable SANDBOX again if needed.
36 - export SANDBOX_ON="${OLD_SANDBOX_ON}"
37 -
38 # Do not break on error, but setup $retval, as we need to kill Xvfb
39 einfo "Xvfb started on DISPLAY=${DISPLAY}"
40 debug-print "${FUNCNAME}: $@"
41 --
42 2.35.1

Replies