Gentoo Archives: gentoo-dev

From: Tim Harder <radhermit@g.o>
To: gentoo-dev@l.g.o
Cc: gentoo-java@l.g.o
Subject: [gentoo-dev] [PATCH] fix java-utils-2 eclass to only use DESTTREE during src_install
Date: Tue, 01 Apr 2014 22:32:14
Message-Id: 20140401223156.GA22353@basil.av1.ca.us.gaikai.int
1 Currently the java-utils-2 eclass refers to $DESTTREE in the
2 java-pkg_init_paths_ function that gets run during pkg_setup (via the
3 java-pkg-2 eclass that calls java-pkg_init). The java-pkg_init_paths_
4 function also gets called again for most src_install java-utils-2 eclass
5 functions that use the related variables but the current implementation
6 doesn't allow the variables to be reset.
7
8 This is an issue for pkg managers that try to follow the spec and don't
9 define DESTTREE outside of src_install. Note that DESTTREE was recently
10 added to pms so you'll probably have to view the live version to see the
11 DESTTREE related info.
12
13 The attached patch fixes the situation by adding java-pkg_init_paths_
14 calls to a couple src_install related functions that use the related
15 variables and removes the call to it during pkg_setup (no related
16 variables appear to be used before src_install but I could be missing
17 something). People familiar with various java pkgs should test it to
18 make sure those variables aren't used before src_install.
19
20 Thoughts or comments welcome,
21 Tim

Attachments

File name MIME type
java-utils-2.eclass.patch text/x-diff

Replies