Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH bash-completion-r1] Introduce get_bashcompdir() to obtain bash-completion dir.
Date: Sat, 27 Apr 2013 15:08:17
Message-Id: 20859.59858.783333.548497@a1i15.kph.uni-mainz.de
In Reply to: Re: [gentoo-dev] [PATCH bash-completion-r1] Introduce get_bashcompdir() to obtain bash-completion dir. by "Michał Górny"
1 >>>>> On Sat, 27 Apr 2013, Micha³ Górny wrote:
2
3 >> > It's better to have a function to obtain that directory rather than for
4 >> > ebuilds to hardcode it.
5 >>
6 >> Why?
7
8 > For better consistency, I'd say. Especially if we decide to fix Gentoo
9 > and start using the standard path, we'd need only to modify the eclass
10 > rather than all involved packages.
11
12 But why should it be a function? Its return value is constant, so
13 a variable defined in the eclass seems more natural.
14
15 Ulrich

Replies