From: "Ulrich Müller" <ulm@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 3/4] cvs.eclass: New eclass variable ECVS_SSH_EXTRA_OPTS
Date: Thu, 17 Oct 2024 18:10:15 +0200 [thread overview]
Message-ID: <u34kuvhg8@gentoo.org> (raw)
In-Reply-To: <CAJ0EP43Z3R+CWA=DeBSXfDcvxvkhfd2fHZ+QaSnKE4t40MO+QA@mail.gmail.com> (Mike Gilbert's message of "Thu, 17 Oct 2024 10:50:40 -0400")
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
>>>>> On Thu, 17 Oct 2024, Mike Gilbert wrote:
>> -oUserKnownHostsFile="${known_hosts_file}" \\
>> -oForwardX11=no \\
>> -oClearAllForwardings=yes \\
>> + ${ECVS_SSH_EXTRA_OPTS[*]} \\
> Why use an array if you're going to collapse it using the "*"
> operator? Maybe use "${ECVS_SSH_EXTRA_OPTS[@]}" instead.
This is in a here-document, so the resulting wrapper script will contain
the variable as one word, i.e. "@" won't result in separate words.
However, I now notice that there is a whitespace issue. Patch v2 will
follow.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2024-10-17 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 5:58 [gentoo-dev] [PATCH 1/4] cvs.eclass: Add local declarations and die statements throughout Ulrich Müller
2024-10-17 5:58 ` [gentoo-dev] [PATCH 2/4] cvs.eclass: Rewrite the ssh wrapper script in bash Ulrich Müller
2024-10-17 5:58 ` [gentoo-dev] [PATCH 3/4] cvs.eclass: New eclass variable ECVS_SSH_EXTRA_OPTS Ulrich Müller
2024-10-17 14:50 ` Mike Gilbert
2024-10-17 16:10 ` Ulrich Müller [this message]
2024-10-17 5:58 ` [gentoo-dev] [PATCH 4/4] app-shells/mksh: Restore live ebuild Ulrich Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u34kuvhg8@gentoo.org \
--to=ulm@gentoo.org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox