From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4D665158042 for ; Thu, 17 Oct 2024 16:10:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 372F0E092B; Thu, 17 Oct 2024 16:10:25 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 05C83E0858 for ; Thu, 17 Oct 2024 16:10:25 +0000 (UTC) From: Ulrich =?utf-8?Q?M=C3=BCller?= To: Mike Gilbert Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 3/4] cvs.eclass: New eclass variable ECVS_SSH_EXTRA_OPTS In-Reply-To: (Mike Gilbert's message of "Thu, 17 Oct 2024 10:50:40 -0400") References: <20241017055843.16396-1-ulm@gentoo.org> <20241017055843.16396-3-ulm@gentoo.org> Date: Thu, 17 Oct 2024 18:10:15 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: 5deb2b17-1374-4f84-8da7-d41d92eb548e X-Archives-Hash: 1329033154a41e892637be9ab9c050ab --=-=-= Content-Type: text/plain >>>>> On Thu, 17 Oct 2024, Mike Gilbert wrote: >> -oUserKnownHostsFile="${known_hosts_file}" \\ >> -oForwardX11=no \\ >> -oClearAllForwardings=yes \\ >> + ${ECVS_SSH_EXTRA_OPTS[*]} \\ > Why use an array if you're going to collapse it using the "*" > operator? Maybe use "${ECVS_SSH_EXTRA_OPTS[@]}" instead. This is in a here-document, so the resulting wrapper script will contain the variable as one word, i.e. "@" won't result in separate words. However, I now notice that there is a whitespace issue. Patch v2 will follow. Ulrich --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmcRNucPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uX3EH+wU02xSzTh2ZweK2AM+QGGO+CZv+DdUsW4zL JKMWQ1ebYXd2Jt5AjzCT3DtKX4SJuWTM801XeF4Aedu78MbqXy1KNtJX8SAHRPXz uKHkDxp5E6jO/RstX4C5nMTwINN9Aj8PU3u9Wm7O5Dh4JbFbbiP2Aa3L9M3dJVG5 xcJp2elY5ccChBQ0+52rb2xGAL0tQxR4z6T3++rUd3dOHntW0DNVl7OsIXGYYOjz G2wOE//Zyum/XpPr7X74R6cY33dmsttOaG8r4mROyKeP04smxX0OLY1NC7FS+a+N VWt205mzHKUThHdRQeDF2uyvIFAPX3BrsGm+wcnbAKoZOt3ybU4= =nhYe -----END PGP SIGNATURE----- --=-=-=--