Re: [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override

[Ulrich Mueller <ulm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

>>>>> On Wed, 06 Jan 2021, Michał Górny wrote:

> On Wed, 2021-01-06 at 14:25 +0100, Ulrich Mueller wrote:
>> I wonder about this line. Both hyphen and underscore are valid
>> characters in user names.
>> 
>> So, ACCT_USER_FOO_BAR_ID would override the id for both foo_bar and
>> foo-bar users.

> I don't think this is the problem we need to be worrying about.  I mean,
> if someone actually created user identifiers that differ only be non-
> alnum characters, I think that'd the problem to tackle.

It is legal to do that, and we already have examples for both hyphen and
underscore in acct-user package names. So the syntax should be able to
cope with it.

A simple mapping from user names (which can contain a hyphen) to
variable names (which cannot) doesn't work and IMHO also violates the
principle of least surprise.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]