From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5A3221580FD for ; Tue, 24 Dec 2024 14:27:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DBEA2E0817; Tue, 24 Dec 2024 14:27:30 +0000 (UTC) Received: from mail-10630.protonmail.ch (mail-10630.protonmail.ch [79.135.106.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9E833E078A for ; Tue, 24 Dec 2024 14:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1735050446; x=1735309646; bh=yQb9ZOfBGloRkHAA7r2Lf6CYUJ9xpOpNfpp+em98e/g=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=d15ibwHf05lNtrJKfpjEqoDT1KcAnVQo6AxJYTBpbwaETgDuYOpO4OopDZ/X03o5y yjWqujsDJcBbRdzsV5IBSd5kypWtinDdyOWpgtfwxL6ODXtgnskId8SaQ9KPIXWp8U 9Unuk9SgVCXDm1NcjpZMRU+pJVC5+5SyALB1rIdOFHr+9s0RxMLcT6A7YgeXCSHoYc kXEnWtowIMoll9Mq0Ipvm3V7je9VVndkx6MrplSOGzW6BdoZwxpuKFzVr7FaTz68Ch etW7ADvLcNUJAzfSK4uOGab7jrcRl0isPFIQY/ZKyRBDb/qPmNbHd6SOmQ5boEiQoo olat5LWheBEhw== Date: Tue, 24 Dec 2024 14:26:43 +0000 To: gentoo-dev@lists.gentoo.org From: Filip Kobierski Subject: Re: [gentoo-dev] TIDAL ebuild Message-ID: In-Reply-To: References: Feedback-ID: 115236665:user:proton X-Pm-Message-ID: 534e5a061c891be048f269511b8a2f8b7dbd1998 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="------5af58697af28f9476095371b4fe863466993826b3306d1ca0fdd5eb2897151b6"; charset=utf-8 X-Archives-Salt: a7a80d8a-e271-4607-878c-1f56a4d54c19 X-Archives-Hash: 3be80b7edcf6ce2e7dba5f5014a597df This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------5af58697af28f9476095371b4fe863466993826b3306d1ca0fdd5eb2897151b6 Content-Type: multipart/mixed;boundary=---------------------fa5b40fca0f843a5dd83c999d93d0ca7 -----------------------fa5b40fca0f843a5dd83c999d93d0ca7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain;charset=utf-8 Hi Daniel, I am no ebuild-master myself but I think I have some feedback; - since it's a -bin package make sure to have -* in KEYWORDS - use desktop.eclass[1]: - domenu for the desktop file - doicon for the icon - also I would use dobin for installing binaries - I would use ${PN} where possible (besides SRC_URI & HOMEPAGE On the name though, is the -bin really nescessary if there is no source option? On one hand we have net-im/discord but on the other there's net-im/discord-canary-bin. Another thing is the -hifi part. For me it implies that before there was some non-hifi version. If that's the case than that is fine to me. I however would name the package tidal-desktop or just tidal. I hope that this helps Filip Kobierski [1]: https://devmanual.gentoo.org/eclass-reference/desktop.eclass/ On Tuesday, December 24th, 2024 at 15:11, Daniel Buschke wrote: > Hi all, > TIDAL is a music streaming service. As I missed a TIDAL desktop app on > gentoo I created an ebuild based on > https://github.com/Mastermindzh/tidal-hifi. > > It's a node js application which drove me a bit crazy. I was today years > old when I realized that the gentoo emerge sandbox is cutting network > access :) > But the node js application, as every node js app, heavily relies on > dependencies, so I decided to go with the binary version. > > Anyway, as I am not very firm with ebuilds it would be nice if someone > could do a review before I try to commit this ebuild to the official > portage via bugs.gentoo.org. Anyone? Thanks in advance. > > https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/tida= l-hifi-bin > > Stay healthy, everyone out there. > > regards > Daniel -----------------------fa5b40fca0f843a5dd83c999d93d0ca7-- --------5af58697af28f9476095371b4fe863466993826b3306d1ca0fdd5eb2897151b6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wnUEARYKACcFgmdqxG4JkAUVAewu4JXrFiEEDDuAKD1tNsX0bzf/BRUB7C7g lesAAHpFAQDJ1SIqljXQosQW5gNFzDN2SpR0PMJwP/tfVzLciqYhAgEA8kry FuTOcIx8mLXWIg0qDpCUNKlki91l6WPc7HXeLwk= =xzbP -----END PGP SIGNATURE----- --------5af58697af28f9476095371b4fe863466993826b3306d1ca0fdd5eb2897151b6--