1 |
On Sunday 31 January 2010 11:18:47 Nikos Chantziaras wrote: |
2 |
> In pkg_setup(): |
3 |
> |
4 |
> if use alsa && use oss ; then |
5 |
> einfo |
6 |
> ewarn "You have enabled both the \"alsa\" as well as the \"oss\" USE |
7 |
> flags. It" |
8 |
> ewarn "is not possible to build mozilla-firefox or xulrunner with |
9 |
> support for" |
10 |
> ewarn "both. ALSA will be used in this case. If you want OSS |
11 |
> support, unset the" |
12 |
> ewarn "\"alsa\" USE flag and leave only \"oss\" set." |
13 |
> fi |
14 |
|
15 |
i personally use terse messages like: |
16 |
You have USE='oss alsa'. It is not possible to use both, so |
17 |
ALSA has been selected by default. |
18 |
i figure the end user can figure out the rest. up to you of course. |
19 |
|
20 |
> In src_configure(): |
21 |
> |
22 |
> # Enable/Disable audio in firefox |
23 |
> if use alsa || use oss ; then |
24 |
> mozconfig_annotate '' --enable-ogg |
25 |
> mozconfig_annotate '' --enable-wave |
26 |
> fi |
27 |
> |
28 |
> |
29 |
> In this last one, I'm not sure how to pass something to the first |
30 |
> argument of mozconfig_annotate. The original was: |
31 |
> |
32 |
> mozconfig_use_enable alsa ogg |
33 |
> |
34 |
> which translates into: |
35 |
> |
36 |
> mozconfig_annotate 'alsa' --enable-ogg |
37 |
> |
38 |
> The point is that the user will see which USE flags are responsible for |
39 |
> "--enable-*" and "--disable-*" options. Unfortunately, this: |
40 |
> |
41 |
> mozconfig_use_enable ( alsa || oss ) ogg |
42 |
> |
43 |
> is not possible. Should I therefore write the block twice in a nested |
44 |
> if block or leave it as is (and losing the information about which USE |
45 |
> flag resulted in "--enable-ogg|wave"?) |
46 |
|
47 |
wouldnt these make more sense behind USE=ogg and USE=wav ? |
48 |
-mike |