1 |
On Sun, 7 Nov 2004, Ned Ludd wrote: |
2 |
|
3 |
> On Wed, 2004-09-22 at 01:15, Peter S. Mazinger wrote: |
4 |
> > On Tue, 21 Sep 2004, David Bryson wrote: |
5 |
> > |
6 |
> > > On Tue, Sep 21, 2004 at 04:51:19PM -0400, Ned Ludd wrote: |
7 |
> > > > Can somebody please review this. I've got my hands full right now. |
8 |
> > > > If it works, it would solve a few problems with some needed/desired |
9 |
> > > > software under uClibc environments more so as it seems glib1 has been |
10 |
> > > > depreciated @ gentoo. |
11 |
> > > > |
12 |
> > > > I'm not sure myself about the free() in the iconv_close() function |
13 |
> > > > without looking at the inner workings of glib2. |
14 |
> > > > |
15 |
> > > > thanks in advance. |
16 |
> > > > |
17 |
> > > |
18 |
> > > PSM + Solar + All |
19 |
> > > I applied the patch and tried to compile glib-2.4.6 with my chroot of |
20 |
> > > spanky's stage3-x86-uclibc-20040909 snapshot. |
21 |
> > > |
22 |
> > > Still died with: |
23 |
> > > configure: error: *** No iconv() implementation found in C library or |
24 |
> > > libiconv |
25 |
> |
26 |
> I worked around that one by changing the AC_MSG_ERROR to AC_MSG_RESULT |
27 |
> so it would echo vs exit. Same for gettext. And ran autoconf to make a |
28 |
> new configure script. glib2 did not seem to respect it but I enabled |
29 |
> enabled --with-libiconv=no. This was still not enough as gconvert.c was |
30 |
> still unconditionally including iconv.h. touching a blank iconv.h in |
31 |
> glib-2.6.7/glib/iconv.h did the trick and allowed it to compile for the |
32 |
> first time. I ended up wrapping an #ifdef around the include file vs |
33 |
> using touch. |
34 |
> |
35 |
> http://oc12.net/~solar/glib-2.4.6-config.patch |
36 |
> http://oc12.net/~solar/glib-2.4.6-no_iconv.patch (updated psm version) |
37 |
> http://oc12.net/~solar/glib-2.4.6.ebuild |
38 |
> |
39 |
> I'm still not sure about that free() in the iconv_close() function. |
40 |
> Don't know if/where memory is being allocated in the first place for the |
41 |
> iconv_t struct. Either we will be trying to free invalid pointers or we |
42 |
> wont. |
43 |
|
44 |
Look at the original iconv_close() function, I have taken it from there (I |
45 |
think from libiconv) |
46 |
|
47 |
Peter |
48 |
|
49 |
> |
50 |
> > |
51 |
> > the patch is not enough, you have to disable gettext and [lib]iconv test |
52 |
> > results too in configure. I am not interested if the patch applies and |
53 |
> > builds (it does already for me), I am interested if the dummy functions |
54 |
> > are written correctly. |
55 |
> > If though interested, I can send you the full patch to allow building on |
56 |
> > uclibc. |
57 |
> > |
58 |
> > Thanks Peter |
59 |
> > |
60 |
> |
61 |
|
62 |
-- |
63 |
Peter S. Mazinger <ps dot m at gmx dot net> ID: 0xA5F059F2 |
64 |
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08 BB6E C389 975E A5F0 59F2 |
65 |
|
66 |
|
67 |
-- |
68 |
gentoo-embedded@g.o mailing list |