[gentoo-hardened] Re: aufs3.0 fails to emerge on Gentoo hardened and kernel 3.0.4

On 5 Jan 2012 at 19:13, Andrea Zuccherelli wrote:

> zrouter aufs # cat kernel-aufs3-no-const-grsec.patch
> --- /usr/src/linux/include/linux/fsnotify_backend.h
> +++ /usr/src/linux/include/linux/fsnotify_backend.h
> @@ -105,6 +105,7 @@ struct fsnotify_ops {
>         void (*freeing_mark)(struct fsnotify_mark *mark, struct
> fsnotify_group *group);
>         void (*free_event_priv)(struct fsnotify_event_private_data *priv);
>  };
> +typedef struct fsnotify_ops __no_const fsnotify_ops_no_const;
>
>  /*
>   * A group is a "thing" that wants to receive notification about filesystem

i've added this to PaX now.

> --- fs/aufs/branch.h
> +++ fs/aufs/branch.h
> @@ -83,7 +83,7 @@ struct au_branch {
>
>  #ifdef CONFIG_AUFS_HFSNOTIFY
>         struct fsnotify_group   *br_hfsn_group;
> -       struct fsnotify_ops     br_hfsn_ops;
> +       fsnotify_ops_no_const   br_hfsn_ops;
>  #endif
>
>  #ifdef CONFIG_SYSFS
>
>
> This should be integrated in Gentoo Hardened aufs3 ebuild,  right?

for current/older versions yes, future ones will have the first chunk
in PaX itself. and maybe in some distant future the plugin will be smart
enough to figure this case out at compile time...

> If #1 could be confirmed then the patch would be in grsec,

both the __no_const and the new typedef would be in PaX in any case, aufs
would always only have to make use of the old/new types.

> but looking for fsnotify_ops use cases I have found only static const initializers
> (inotify for instance).

yes, that's why there was no extra no_const typedef for it so far, but now
there is. i could of course proactively add such typedefs to all otherwise
constified ops types but i'd rather not make my own life harder when it comes
to porting to a new version ;).