Gentoo Archives: gentoo-java

From: Mario Fetka <mario.fetka@×××××.com>
To: gentoo-java@l.g.o
Subject: Re: [gentoo-java] plz review some ebuilds
Date: Mon, 04 May 2009 18:50:56
Message-Id: 200905042050.54709.mario.fetka@gmail.com
In Reply to: Re: [gentoo-java] plz review some ebuilds by Vlastimil Babka
1 On Monday, 4. May 2009 20:33:11 Vlastimil Babka wrote:
2 > Mario Fetka wrote:
3 > > Hallo Gentoo Java Team,
4 > >
5 > > can someone plz review some java related ebuilds[1]
6 > >
7 > > dev-java/isrt
8 > > dev-java/isnativec
9 > > dev-java/isfreetype
10 > > dev-java/iscwt
11 > > dev-java/jPod
12 > > dev-java/jPodRenderer
13 > > dev-java/jbig2
14 > > app-text/pdfsam
15 >
16 > Hi, just a quick... I'll talk about iscwt-5.0.20081218.ebuild but most
17 > should apply to others too.
18 >
19 > depends on swt:3.4 using a slot dep without EAPI=1 (or later) which
20 > should not even work. In general, use EAPI=2 and specify slot deps for
21 > everything dev-java except jdk/jre (even explicitly :0 as it eases
22 > future upgrades). With EAPI=2 you can call 'default' instead of 'unpack
23 > $A; cd $S;'. The mkdir and cp calls should have appen '|| die'
24 >
25 > Move doc from IUSE to JAVA_PKG_IUSE.
26 > The creation of build.properties is tedious, overriding the classpath
27 > (see below) should be easier.
28 > What is the ${antflags} doing in src_compile? Should not be there. Also
29 > there should be just one eant call and using $(use_doc) as parameter
30 > will add 'javadoc' based on the flag.
31 > Also the whole src_compile (and the build.properties stuff) could be
32 > replaced with this:
33 >
34 > JAVA_ANT_REWRITE_CLASSPATH="true"
35 > EANT_GENTOO_CLASSPATH="isnativec,isrt,jna"
36 >
37 > Not tested, so some details might vary. Hope it helps.
38 > Caster
39 >
40 > > before i will put them into bugzilla
41 > >
42 > > thx in av
43 > > Mario
44 > >
45 > > [1]http://tinyurl.com/co97l6
46 > > http://tinyurl.com/dg3vhv
47
48 thx for the help
49 will implement the suggested changes
50
51 Mario