Gentoo Archives: gentoo-perl

From: Michael Cummings <mcummings@g.o>
To: gentoo-perl@l.g.o
Subject: Re: [gentoo-perl]
Date: Thu, 12 May 2005 12:11:43
In Reply to: [gentoo-perl] by "David (Sniper) Rigaudiere"
On Wednesday 11 May 2005 09:56 pm, David (Sniper) Rigaudiere wrote:
> - get rid of \t, and use of 4 spaces as perlstyle :)
> - get rid of system(mv ...) use File::Copy::move()
> > # FIXME Sniper > # the defined() seems mistakes, we want the defined status or ENV values
Ah, but when you run this code and the env var isn't defined - you get a broken script that dies on an undeclared var (a la strict and warnings). I added the defines to keep it from choking for those of us that don't have ENV{TMPDIR,ftp_proxy,http_proxy} set. These are the vars portage and cpan use if defined - but if not defined, they don't care - but when trying to set values (and under use strict) we need someway of dealing with them not even existing (vs undef). One of those undef != non-exist - because undef is a value in itself, and in this case the values simply don't exist to test.
> ??? my $tmp_dir = -d $ENV{TMPDIR} ? defined($ENV{TMPDIR}) : > $ENV{HOME}; > my $ftp_proxy = $ENV{ftp_proxy} ? defined($ENV{ftp_proxy}) : ''; > my $http_proxy = $ENV{http_proxy} ? defined($ENV{http_proxy}) : ''; > my $user_shell = -x $ENV{SHELL} ? defined($ENV{SHELL}) : > DEF_BASH_PROG; > > > > > David "Sniper" Rigaudiere > GPG KeyID 0xFF1E982D
-- -----o()o--------------------------------------------- Michael Cummings | #gentoo-dev, #gentoo-perl Gentoo Perl Dev | on -----o()o---------------------------------------------


Subject Author
Réf. : Re: [gentoo-perl] antoine.raillon@××××.com