Gentoo Archives: gentoo-pms

From: "Michał Górny" <mgorny@g.o>
To: gentoo-pms@l.g.o
Cc: "Ulrich Müller" <ulm@g.o>
Subject: Re: [gentoo-pms] [PATCH] ebuild-env-vars.tex: Clarify wording for profile IUSE injection
Date: Thu, 15 Apr 2021 08:50:01
Message-Id: 3b89d274a14fcace24240576f124a6a1b0a1a083.camel@gentoo.org
In Reply to: [gentoo-pms] [PATCH] ebuild-env-vars.tex: Clarify wording for profile IUSE injection by "Ulrich Müller"
1 On Thu, 2021-04-15 at 10:09 +0200, Ulrich Müller wrote:
2 > Subsume IUSE_REFERENCEABLE and IUSE_EFFECTIVE under a single
3 > conditional, which will clarify that these variables are equal if the
4 > feature is supported.
5 >
6 > Also the profile-iuse-inject featurelabel was misplaced (it didn't
7 > cover IUSE_REFERENCEABLE).
8 >
9 > Signed-off-by: Ulrich Müller <ulm@g.o>
10 > ---
11 >  ebuild-env-vars.tex | 11 ++++-------
12 >  1 file changed, 4 insertions(+), 7 deletions(-)
13 >
14 > diff --git a/ebuild-env-vars.tex b/ebuild-env-vars.tex
15 > index 117a19d..2736423 100644
16 > --- a/ebuild-env-vars.tex
17 > +++ b/ebuild-env-vars.tex
18 > @@ -375,12 +375,8 @@ In all cases, the values of \t{IUSE_REFERENCEABLE} and \t{IUSE_EFFECTIVE} are un
19 >  metadata generation.
20 >  
21 >
22 >  For EAPIs listed in table~\ref{tab:profile-iuse-injection-table} as not supporting profile defined
23 > -\t{IUSE} injection, \t{IUSE_REFERENCEABLE} is equal to the calculated \t{IUSE} value. For EAPIs
24 > -where profile defined \t{IUSE} injection is supported, \t{IUSE_REFERENCEABLE} is equal to
25 > -\t{IUSE_EFFECTIVE}.
26 > -
27 > -For EAPIs listed in table~\ref{tab:profile-iuse-injection-table} as not supporting profile defined
28 > -\t{IUSE} injection, \t{IUSE_EFFECTIVE} contains the following values:
29 > +\t{IUSE} injection, \t{IUSE_REFERENCEABLE} is equal to the calculated \t{IUSE} value, and
30 > +\t{IUSE_EFFECTIVE} contains the following values:
31 >  
32 >
33 >  \begin{compactitem}
34 >  \item All values in the calculated \t{IUSE} value.
35 > @@ -390,7 +386,8 @@ For EAPIs listed in table~\ref{tab:profile-iuse-injection-table} as not supporti
36 >  \end{compactitem}
37 >  
38 >
39 >  \featurelabel{profile-iuse-inject} For EAPIs listed in table~\ref{tab:profile-iuse-injection-table}
40 > -as supporting profile defined \t{IUSE} injection, \t{IUSE_EFFECTIVE} contains the following values:
41 > +as supporting profile defined \t{IUSE} injection, \t{IUSE_REFERENCEABLE} and \t{IUSE_EFFECTIVE}
42 > +are equal and contain the following values:
43 >  
44 >
45 >  \begin{compactitem}
46 >  \item All values in the calculated \t{IUSE} value.
47
48 LGTM.
49
50 --
51 Best regards,
52 Michał Górny