| 1 |
>>>>> On Sat, 17 Feb 2018, Michał Górny wrote: |
| 2 |
|
| 3 |
> --- a/pkg-mgr-commands.tex |
| 4 |
> +++ b/pkg-mgr-commands.tex |
| 5 |
> @@ -340,6 +340,9 @@ current phase function has returned. |
| 6 |
> \item -{}-with-sysroot must be \t{\$\{ESYSROOT\}}, if the EAPI is listed in |
| 7 |
> table~\ref{tab:econf-options-table} as using it. This option will only be passed if the |
| 8 |
> string \t{-{}-with-sysroot} occurs in the output of \t{configure -{}-help}. |
| 9 |
> + \item -{}-build must be the value of the \t{CBUILD} environment variable, if the EAPI is listed |
| 10 |
> + table~\ref{tab:econf-options-table} as using it. This option will only be passed if the |
| 11 |
|
| 12 |
s/table/in table/ |
| 13 |
|
| 14 |
> + \t{CBUILD} variable is set to a non-empty value. |
| 15 |
> \item -{}-host must be the value of the \t{CHOST} environment variable. |
| 16 |
> \item -{}-libdir must be set according to Algorithm~\ref{alg:econf-libdir}. |
| 17 |
> \item -{}-disable-dependency-tracking, if the EAPI is listed in |
| 18 |
> @@ -353,20 +356,21 @@ current phase function has returned. |
| 19 |
> \ChangeWhenAddingAnEAPI{7} |
| 20 |
> \begin{centertable}{Extra \t{econf} arguments for EAPIs} |
| 21 |
> \label{tab:econf-options-table} |
| 22 |
> - \begin{tabular}{llllll} |
| 23 |
> + \begin{tabular}{lllllll} |
| 24 |
> \toprule |
| 25 |
> \multicolumn{1}{c}{\textbf{EAPI}} & |
| 26 |
> - \multicolumn{1}{P{9em}}{\textbf{-{}-disable-dependency-tracking}} & |
| 27 |
> + \multicolumn{1}{P{5em}}{\textbf{-{}-disable-dependency-tracking}} & |
| 28 |
|
| 29 |
This causes an overfull box. Rather leave it at 9em (which will also |
| 30 |
save a line) but change --with-sysroot below to P{3em}. |
| 31 |
|
| 32 |
> \multicolumn{1}{P{5em}}{\textbf{-{}-disable-silent-rules}} & |
| 33 |
> \multicolumn{1}{c}{\textbf{-{}-docdir}} & |
| 34 |
> \multicolumn{1}{c}{\textbf{-{}-htmldir}} & |
| 35 |
> - \multicolumn{1}{c}{\textbf{-{}-with-sysroot}} \\ |
| 36 |
> + \multicolumn{1}{c}{\textbf{-{}-with-sysroot}} & |
| 37 |
> + \multicolumn{1}{c}{\textbf{-{}-build}} \\ |
| 38 |
> \midrule |
| 39 |
> - 0, 1, 2, 3 & No & No & No & No & No \\ |
| 40 |
> - 4 & Yes & No & No & No & No \\ |
| 41 |
> - 5 & Yes & Yes & No & No & No \\ |
| 42 |
> - 6 & Yes & Yes & Yes & Yes & No \\ |
| 43 |
> - 7 & Yes & Yes & Yes & Yes & Yes \\ |
| 44 |
> + 0, 1, 2, 3 & No & No & No & No & No & No \\ |
| 45 |
> + 4 & Yes & No & No & No & No & No \\ |
| 46 |
> + 5 & Yes & Yes & No & No & No & No \\ |
| 47 |
> + 6 & Yes & Yes & Yes & Yes & No & No \\ |
| 48 |
> + 7 & Yes & Yes & Yes & Yes & Yes & Yes \\ |
| 49 |
> \bottomrule |
| 50 |
> \end{tabular} |
| 51 |
> \end{centertable} |
| 52 |
|
| 53 |
Otherwise LGTM. |
| 54 |
|
| 55 |
Ulrich |
Archives