Gentoo Archives: gentoo-pms

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-pms@l.g.o
Subject: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6
Date: Wed, 14 Oct 2015 19:40:13
Message-Id: 22046.44947.632440.622556@a1i15.kph.uni-mainz.de
In Reply to: [gentoo-pms] [PATCH v2] Explain eapply behavior for EAPI 6 by "Michał Górny"
1 >>>>> On Wed, 14 Oct 2015, Michał Górny wrote:
2
3 > +\IF{any parameter is equal to \t{"-{}-"}}
4 > + \STATE collect all parameters before the first \t{"-{}-"} in the options array
5 > + \STATE collect all parameters after the first \t{"-{}-"} in the files array
6
7 Hm, I previously had "IF the first parameter begins with a hyphen AND
8 any parameter is equal to --", because the first parameter certainly
9 cannot be an option argument.
10
11 > +\ELSIF{any parameter beginning with a hyphen follows one that does not begin with a hyphen}
12 > + \STATE abort the build process with an error
13
14 I suggest "return immediately with an error" here, for consistency
15 with the wording below.
16
17 > + \IF{spawned patch process returns with non-zero exit status}
18
19 I think "child process" is better here.
20
21 > + \STATE return immediately with an error
22 > + \ENDIF
23
24 Ulrich

Replies

Subject Author
Re: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6 "Michał Górny" <mgorny@g.o>