Gentoo Archives: gentoo-pms

From: "Michał Górny" <mgorny@g.o>
To: gentoo-pms@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-pms] [PATCH] pkg-mgr-commands: Correct 'empty' insopts behavior to match PMs
Date: Fri, 08 Jun 2018 11:51:28
Message-Id: 20180608115120.7042-1-mgorny@gentoo.org
1 My previous fix to insopts turns out twice wrong: firstly, because I did
2 not really type what I meant, and secondly because package managers have
3 inconsistent behavior there. Portage uses the default mode (specified
4 by PMS) when insopts was called with no arguments or arguments forming
5 an empty string; PkgCore and Paludis literally pass empty argument list
6 to install. Mark the behavior as undefined to match that.
7 ---
8 pkg-mgr-commands.tex | 5 ++---
9 1 file changed, 2 insertions(+), 3 deletions(-)
10
11 diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
12 index 01c0c6d..031638a 100644
13 --- a/pkg-mgr-commands.tex
14 +++ b/pkg-mgr-commands.tex
15 @@ -725,9 +725,8 @@ function has returned.
16
17 \item[docinto] As \t{into}, for install subdirectory of \t{dodoc} et al.
18
19 -\item[insopts] Takes zero or more arguments, and sets the options passed by \t{doins} et al.\
20 - to the \t{install} command to them. When called with no arguments, resets the option list
21 - to empty.
22 +\item[insopts] Takes one or more arguments, and sets the options passed by \t{doins} et al.\
23 + to the \t{install} command to them. Behavior upon encountering empty arguments is undefined.
24
25 \item[diropts] As \t{insopts}, for \t{dodir} et al.
26
27 --
28 2.18.0.rc1

Replies