Gentoo Archives: gentoo-pms

From: "Michał Górny" <mgorny@g.o>
To: Ulrich Mueller <ulm@g.o>
Cc: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6
Date: Wed, 14 Oct 2015 19:55:27
Message-Id: 20151014215504.0c3b7b3c.mgorny@gentoo.org
In Reply to: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6 by Ulrich Mueller
1 Dnia 2015-10-14, o godz. 21:40:03
2 Ulrich Mueller <ulm@g.o> napisał(a):
3
4 > >>>>> On Wed, 14 Oct 2015, Michał Górny wrote:
5 >
6 > > +\IF{any parameter is equal to \t{"-{}-"}}
7 > > + \STATE collect all parameters before the first \t{"-{}-"} in the options array
8 > > + \STATE collect all parameters after the first \t{"-{}-"} in the files array
9 >
10 > Hm, I previously had "IF the first parameter begins with a hyphen AND
11 > any parameter is equal to --", because the first parameter certainly
12 > cannot be an option argument.
13
14 I know. But does it really make a difference in our case? I wanted to
15 try to make the algorithm a little simpler.
16
17 >
18 > > +\ELSIF{any parameter beginning with a hyphen follows one that does not begin with a hyphen}
19 > > + \STATE abort the build process with an error
20 >
21 > I suggest "return immediately with an error" here, for consistency
22 > with the wording below.
23
24 Well, I wanted to emphasize difference in error handling. patch failing
25 implies error exit with respect to nonfatal. Usage error is
26 unconditional die.
27
28 >
29 > > + \IF{spawned patch process returns with non-zero exit status}
30 >
31 > I think "child process" is better here.
32
33 Updated.
34
35 --
36 Best regards,
37 Michał Górny
38 <http://dev.gentoo.org/~mgorny/>

Replies